-
Notifications
You must be signed in to change notification settings - Fork 948
Add app
property to public typings of all services
#5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Changeset File Check
|
Binary Size ReportAffected SDKsNo changes between base commit (7818176) and head commit (06637ce). Test Logs
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for perf. Thanks for making the changes!
Size Analysis Report |
Co-authored-by: Feiyang <[email protected]>
Every service has an
app
property publicly exposed so we should probably have the typings for that. Went through and added the typing to products that did not have it.Fixes #5346