Skip to content

Add app property to public typings of all services #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

Every service has an app property publicly exposed so we should probably have the typings for that. Went through and added the typing to products that did not have it.

Fixes #5346

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2021

⚠️ No Changeset found

Latest commit: 13926c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 23, 2021

Binary Size Report

Affected SDKs

No changes between base commit (7818176) and head commit (06637ce).

Test Logs

@google-cla
Copy link

google-cla bot commented Aug 23, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@hsubox76 hsubox76 changed the base branch from master to fei-v9-main August 23, 2021 17:46
Copy link
Contributor

@jposuna jposuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for perf. Thanks for making the changes!

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 23, 2021

Size Analysis Report

Affected Products

No changes between base commit (7818176) and head commit (06637ce).

@Feiyang1 Feiyang1 merged commit c6076eb into fei-v9-main Aug 23, 2021
@Feiyang1 Feiyang1 deleted the ch-app-prop branch August 23, 2021 20:20
@firebase firebase locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Types][v9] Missing [api].app typings for Auth, Performance, and Remote Config
4 participants