Clean up things from v9 beta

.github/workflows/check-changeset.yml

@@ -24,7 +24,7 @@ jobs:
     - name: Yarn install
       run: yarn
     - name: Run changeset script
-      run: yarn ts-node-script scripts/check_changeset.ts
+      run: yarn ts-node-script scripts/ci/check_changeset.ts
       id: check-changeset
     - name: Print changeset checker output
       run: echo "${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}"

.github/workflows/label-doc-changes.yml

@@ -24,7 +24,7 @@ jobs:
     - name: Yarn install
       run: yarn
     - name: Run detect doc changes script
-      run: yarn ts-node-script scripts/exp/detect-doc-changes.ts
+      run: yarn ts-node-script scripts/ci/detect-doc-changes.ts
       id: check-doc-changes
     - name: Print if doc changed output
       run: echo "${{steps.check-doc-changes.outputs.DOC_CHANGED}}"

.github/workflows/release.yml

@@ -25,7 +25,7 @@ jobs:
         run: yarn
 
       - name: Add a changeset for @firebase/app
-        run: yarn ts-node-script scripts/add_changeset.ts
+        run: yarn ts-node-script scripts/ci/add_changeset.ts
 
       - name: Create Release Pull Request
         uses: changesets/action@master

package.json

@@ -38,16 +38,16 @@
     "test:changed": "ts-node-script scripts/ci-test/test_changed.ts",
     "test:setup": "node tools/config.js",
     "test:saucelabs": "node scripts/run_saucelabs.js",
-    "docgen:js": "node scripts/docgen/generate-docs.js --api js",
-    "docgen:node": "node scripts/docgen/generate-docs.js --api node",
-    "docgen": "yarn docgen:js; yarn docgen:node",
+    "docgen": "ts-node-script scripts/docgen/docgen.ts",
+    "docgen:compat": "yarn docgen:compat:js; yarn docgen:compat:node",
+    "docgen:compat:js": "node scripts/docgen-compat/generate-docs.js --api js",
+    "docgen:compat:node": "node scripts/docgen-compat/generate-docs.js --api node",
     "prettier": "prettier --config .prettierrc --write '**/*.{ts,js}'",
     "lint": "lerna run --scope @firebase/* lint",
     "lint:fix": "lerna run --scope @firebase/* lint:fix",
     "size-report": "ts-node-script scripts/size_report/report_binary_size.ts",
     "modular-export-size-report": "ts-node-script scripts/size_report/report_modular_export_binary_size.ts",
     "api-report": "lerna run --scope @firebase/* api-report",
-    "docgen:exp": "ts-node-script scripts/exp/docgen.ts",
     "postinstall": "yarn --cwd repo-scripts/changelog-generator build",
     "sa": "ts-node-script repo-scripts/size-analysis/cli.ts",
     "api-documenter-devsite": "ts-node-script repo-scripts/api-documenter/src/start.ts"
@@ -139,7 +139,6 @@
     "ora": "5.4.1",
     "prettier": "2.3.1",
     "protractor": "5.4.2",
-    "rxjs": "6.6.3",
     "semver": "7.3.4",
     "simple-git": "2.40.0",
     "sinon": "9.2.2",

packages/analytics-compat/package.json

@@ -39,7 +39,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser",
     "test:browser": "karma start --single-run",
     "test:browser:debug": "karma start --browsers=Chrome --auto-watch",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../analytics/dist/analytics-public.d.ts -o dist/src/index.d.ts -a -r Analytics:FirebaseAnalytics -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/analytics"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../analytics/dist/analytics-public.d.ts -o dist/src/index.d.ts -a -r Analytics:FirebaseAnalytics -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/analytics"
   },
   "typings": "dist/src/index.d.ts",
   "dependencies": {

packages/analytics/package.json

@@ -24,7 +24,7 @@
     "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/analytics-public.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/analytics-public.d.ts"
   },
   "peerDependencies": {
     "@firebase/app": "0.x"

packages/app-check-compat/package.json

@@ -19,7 +19,7 @@
     "test": "run-p lint test:browser",
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser",
     "test:browser": "karma start --single-run --nocache",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../app-check/dist/app-check-public.d.ts -o dist/src/index.d.ts -a -r AppCheck:FirebaseAppCheck -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/app-check"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../app-check/dist/app-check-public.d.ts -o dist/src/index.d.ts -a -r AppCheck:FirebaseAppCheck -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/app-check"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages/app-check/package.json

@@ -22,7 +22,7 @@
     "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/app-check-public.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/app-check-public.d.ts"
   },
   "peerDependencies": {
     "@firebase/app": "0.x"

packages/app/package.json

@@ -24,8 +24,8 @@
     "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/app-public.d.ts",
-    "typings:internal": "node ../../scripts/exp/use_typings.js ./dist/app.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/app-public.d.ts",
+    "typings:internal": "node ../../scripts/build/use_typings.js ./dist/app.d.ts"
   },
   "dependencies": {
     "@firebase/util": "1.3.0",

packages/auth-compat/demo/package.json

@@ -30,7 +30,6 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "@rollup/plugin-commonjs": "17.1.0",
-    "rollup-plugin-license": "0.14.0",
     "@rollup/plugin-node-resolve": "11.2.0",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.30.0",

packages/auth-compat/package.json

@@ -25,7 +25,7 @@
     "test:node:integration": "ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --integration",
     "test:webdriver": "rollup -c test/integration/webdriver/static/rollup.config.js && ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --webdriver",
     "test:integration": "firebase emulators:exec --project demo-emulatedproject --only auth \"run-s test:browser:integration test:node:integration test:webdriver\"",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../auth/dist/auth-public.d.ts -o dist/auth-compat/index.d.ts -a -r Auth:types.FirebaseAuth -r User:types.User -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/auth"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../auth/dist/auth-public.d.ts -o dist/auth-compat/index.d.ts -a -r Auth:types.FirebaseAuth -r User:types.User -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/auth"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages/auth/api-extractor.json

@@ -1,7 +1,5 @@
 {
     "extends": "../../config/api-extractor.json",
-    // If this path ever changes, make sure to change scripts/exp/docgen.ts
-    // accordingly.
     "mainEntryPointFilePath": "<projectFolder>/dist/esm5/index.d.ts",
     "dtsRollup": {
         "enabled": true,

packages/auth/package.json

@@ -44,7 +44,7 @@
     "api-report": "api-extractor run --local --verbose && ts-node-script ../../repo-scripts/prune-dts/prune-dts.ts --input dist/auth-public.d.ts --output dist/auth-public.d.ts",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/auth-public.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/auth-public.d.ts"
   },
   "peerDependencies": {
     "@firebase/app": "0.x"

packages/database-compat/package.json

@@ -21,7 +21,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test",
     "test:browser": "karma start --single-run",
     "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../database/dist/public.d.ts -o dist/database-compat/src/index.d.ts -a -r Database:types.FirebaseDatabase -r Query:types.Query -r DatabaseReference:types.Reference -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/database"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../database/dist/public.d.ts -o dist/database-compat/src/index.d.ts -a -r Database:types.FirebaseDatabase -r Query:types.Query -r DatabaseReference:types.Reference -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/database"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages/database/package.json

@@ -13,7 +13,7 @@
   "scripts": {
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts'  --ignore-path '../../.gitignore'",
-    "prettier": "prettier --write '*.js' '*.ts' '@(exp|src|test)/**/*.ts'",
+    "prettier": "prettier --write '*.js' '*.ts' '@(src|test)/**/*.ts'",
     "build": "rollup -c rollup.config.js && yarn api-report",
     "build:deps": "lerna run --scope @firebase/'{app,database}' --include-dependencies build",
     "dev": "rollup -c -w",
@@ -26,7 +26,7 @@
     "api-report": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package database --packageRoot . --typescriptDts ./dist/src/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/public.d.ts && yarn api-report:api-json",
     "api-report:api-json": "rm -rf temp && api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/public.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/public.d.ts"
   },
   "license": "Apache-2.0",
   "peerDependencies": {},

packages/database/src/core/view/EventRegistration.ts

@@ -27,7 +27,7 @@ import { QueryParams } from './QueryParams';
 
 /**
  * A user callback. Callbacks issues from the Legacy SDK maintain references
- *  to the original user-issued callbacks, which allows equality
+ * to the original user-issued callbacks, which allows equality
  * comparison by reference even though this callbacks are wrapped before
  * they can be passed to the firebase@exp SDK.
  *

packages/firebase/package.json

@@ -248,7 +248,6 @@
   "devDependencies": {
     "rollup": "2.52.2",
     "@rollup/plugin-commonjs": "17.1.0",
-    "rollup-plugin-license": "2.5.0",
     "@rollup/plugin-node-resolve": "11.2.0",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-terser": "7.0.2",

packages/firestore-compat/package.json

@@ -17,7 +17,7 @@
     "build:deps": "lerna run --scope @firebase/firestore-compat --include-dependencies build",
     "build:release": "yarn build && yarn add-compat-overloads",
     "test": "echo 'tested as part of firestore'",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../firestore/dist/index.d.ts -o dist/src/index.d.ts -a -r Firestore:types.FirebaseFirestore -r CollectionReference:types.CollectionReference -r DocumentReference:types.DocumentReference -r Query:types.Query -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/firestore"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../firestore/dist/index.d.ts -o dist/src/index.d.ts -a -r Firestore:types.FirebaseFirestore -r CollectionReference:types.CollectionReference -r DocumentReference:types.DocumentReference -r Query:types.Query -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/firestore"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages/firestore-compat/src/config.ts

@@ -25,7 +25,7 @@ import {
   CACHE_SIZE_UNLIMITED,
   GeoPoint,
   Timestamp
-} from '@firebase/firestore'; // import from the exp public API
+} from '@firebase/firestore';
 
 import { Blob } from './api/blob';
 import {

packages/firestore/karma.conf.js

@@ -55,9 +55,6 @@ function getTestFiles(argv) {
     process.env.TEST_PLATFORM = 'browser_lite';
     return [liteIntegrationTests];
   } else {
-    // Note that we cannot include both the firestore-exp and the legacy SDK
-    // as the test runners modify the global namespace cannot be both included
-    // in the same bundle.
     return [unitTests, legcayIntegrationTests];
   }
 }

packages/firestore/package.json

@@ -43,7 +43,7 @@
     "api-report": "run-s api-report:main api-report:lite && yarn api-report:api-json",
     "doc": "api-documenter markdown --input temp --output docs",
     "test:prepare": "node ./scripts/prepare-test.js",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/index.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/index.d.ts"
   },
   "main": "dist/index.node.cjs.js",
   "main-esm": "dist/index.node.cjs.esm2017.js",

packages/firestore/rollup.config.lite.js

@@ -25,7 +25,6 @@ import sourcemaps from 'rollup-plugin-sourcemaps';
 import copy from 'rollup-plugin-copy';
 import replace from 'rollup-plugin-replace';
 import { terser } from 'rollup-plugin-terser';
-import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
 
 import pkg from './lite/package.json';
 
@@ -42,7 +41,7 @@ const nodePlugins = function () {
       },
       cacheDir: tmp.dirSync(),
       abortOnError: false,
-      transformers: [util.removeAssertTransformer, importPathTransformer]
+      transformers: [util.removeAssertTransformer]
     }),
     json({ preferConst: true }),
     copy({
@@ -70,10 +69,7 @@ const browserPlugins = function () {
       },
       cacheDir: tmp.dirSync(),
       abortOnError: false,
-      transformers: [
-        util.removeAssertAndPrefixInternalTransformer,
-        importPathTransformer
-      ]
+      transformers: [util.removeAssertAndPrefixInternalTransformer]
     }),
     json({ preferConst: true }),
     terser(util.manglePrivatePropertiesOptions)

packages/firestore/rollup.shared.js

@@ -119,16 +119,6 @@ const removeAssertTransformer = service => ({
 });
 exports.removeAssertTransformer = removeAssertTransformer;
 
-/**
- * Transformer that coverts import paths that match `exp/index` to `@firebase/firestore`
- * and `lite/index` to `@firebase/firestore/lite`
- */
-const importTransformer = service => ({
-  before: [removeAsserts(service.getProgram())],
-  after: []
-});
-exports.importTransformer = importTransformer;
-
 /**
  * Transformers that remove calls to `debugAssert`, messages for 'fail` and
  * `hardAssert` and appends a __PRIVATE_ prefix to all internal symbols.

packages/functions-compat/package.json

@@ -42,7 +42,7 @@
     "test:browser:debug": "karma start --browsers=Chrome --auto-watch",
     "test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
     "test:emulator": "env FIREBASE_FUNCTIONS_HOST=http://localhost FIREBASE_FUNCTIONS_PORT=5005 run-p test:node",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../functions/dist/functions-public.d.ts -o dist/src/index.d.ts -a -r Functions:types.FirebaseFunctions -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/functions"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../functions/dist/functions-public.d.ts -o dist/src/index.d.ts -a -r Functions:types.FirebaseFunctions -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/functions"
   },
   "typings": "dist/src/index.d.ts",
   "dependencies": {

packages/functions/package.json

@@ -26,7 +26,7 @@
     "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/functions-public.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/functions-public.d.ts"
   },
   "license": "Apache-2.0",
   "peerDependencies": {

packages/installations/package.json

@@ -28,8 +28,8 @@
     "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/installations-public.d.ts",
-    "typings:internal": "node ../../scripts/exp/use_typings.js ./dist/src/index.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/installations-public.d.ts",
+    "typings:internal": "node ../../scripts/build/use_typings.js ./dist/src/index.d.ts"
   },
   "repository": {
     "directory": "packages/installations",

packages/messaging-compat/package.json

@@ -24,7 +24,7 @@
     "test:karma": "karma start --single-run",
     "test:debug": "karma start --browsers=Chrome --auto-watch",
     "type-check": "tsc --noEmit",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging/dist/index-public.d.ts -o dist/src/index.d.ts -a -r Messaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../messaging/dist/index-public.d.ts -o dist/src/index.d.ts -a -r Messaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages/messaging/package.json

@@ -29,7 +29,7 @@
     "api-report:sw": "ts-node-script ../../repo-scripts/prune-dts/extract-public-api.ts --package messaging-sw --packageRoot . --typescriptDts ./dist/index.sw.d.ts --rollupDts ./dist/sw/private.d.ts --untrimmedRollupDts ./dist/sw/internal.d.ts --publicDts ./dist/sw/index-public.d.ts",
     "api-report:api-json": "api-extractor run --local --verbose",
     "type-check": "tsc --noEmit",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/index-public.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/index-public.d.ts"
   },
   "license": "Apache-2.0",
   "peerDependencies": {

packages/performance-compat/package.json

@@ -22,7 +22,7 @@
     "test:browser": "karma start --single-run",
     "test:browser:debug": "karma start --browsers Chrome --auto-watch",
     "prettier": "prettier --write '{src,test}/**/*.{js,ts}'",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../performance/dist/src/index.d.ts -o dist/src/index.d.ts -a -r FirebasePerformance:FirebasePerformanceCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/performance"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../performance/dist/src/index.d.ts -o dist/src/index.d.ts -a -r FirebasePerformance:FirebasePerformanceCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/performance"
   },
   "license": "Apache-2.0",
   "peerDependencies": {

packages/remote-config-compat/package.json

@@ -21,7 +21,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
     "test:browser": "karma start --single-run",
     "test:browser:debug": "karma start --browsers Chrome --auto-watch",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../remote-config/dist/remote-config-public.d.ts -o dist/src/index.d.ts -a -r RemoteConfig:RemoteConfigCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/remote-config"
+    "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../remote-config/dist/remote-config-public.d.ts -o dist/src/index.d.ts -a -r RemoteConfig:RemoteConfigCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/remote-config"
   },
   "license": "Apache-2.0",
   "peerDependencies": {

packages/remote-config/package.json

@@ -24,8 +24,8 @@
     "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
-    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/remote-config-public.d.ts",
-    "typings:internal": "node ../../scripts/exp/use_typings.js ./dist/src/index.d.ts"
+    "typings:public": "node ../../scripts/build/use_typings.js ./dist/remote-config-public.d.ts",
+    "typings:internal": "node ../../scripts/build/use_typings.js ./dist/src/index.d.ts"
   },
   "peerDependencies": {
     "@firebase/app": "0.x"