Disable fcm integration test until it's fixed #5479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zwu52
approved these changes
Sep 10, 2021
|
b/197968624 to fix |
hsubox76
reviewed
Sep 14, 2021
| @@ -30,8 +30,8 @@ | |||
| "repl": "node tools/repl.js", | |||
| "release": "ts-node-script scripts/release/cli.ts", | |||
| "pretest": "node tools/pretest.js", | |||
| "test": "lerna run --ignore firebase-repo-scripts-prune-dts --ignore firebase-messaging-integration-test --concurrency 4 --stream test", | |||
| "test:ci": "lerna run --concurrency 4 test:ci", | |||
| "test": "lerna run --ignore firebase-messaging-integration-test --concurrency 4 --stream test", | |||
There was a problem hiding this comment.
The firebase-repo-scripts-prune-dts is ok to run now?
There was a problem hiding this comment.
Ran it locally without an issue.
hsubox76
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will enable it once it's fixed. To reenable it, revert this PR and manually enable the workflow in GHA.