Skip to content

Fix workflow that automatically publishes @firebase/app #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 13, 2021

@firebase/app should be published on every release. The script to automatically do this was failing because yarn changesets status couldn't find the master branch locally, because actions/checkout doesn't check it out locally. After reproducing locally, it does seem to be able to access origin/master, so changed it to that.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2021

⚠️ No Changeset found

Latest commit: 7b5fec0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1
Copy link
Member

LG. Thanks. Can we run the workflow in Github to make sure it actually works?

@hsubox76
Copy link
Contributor Author

I don't think we can test the workflow without merging it because reproducing the exact git state means it has to be on a push to the release branch, and that won't trigger if it's not merged to master. I reproduced it as much as possible locally by manually doing the same weird git checkout steps that actions/checkout does.

@hsubox76 hsubox76 merged commit 5afd053 into master Sep 15, 2021
@hsubox76 hsubox76 deleted the ch-version-fix-2 branch September 15, 2021 00:23
@firebase firebase locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants