Skip to content

Fix changeset checker to stop using since option #5555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 27, 2021

The option doesn't do what I thought it did, it should be calling the normal changeset status command. It just needs to explicitly pull master first so that the command doesn't fail.

--no-rebase avoids the warning message of not specifying a default merge strategy while selecting what would have been the default anyway.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2021

⚠️ No Changeset found

Latest commit: c19a25d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 27, 2021
@hsubox76 hsubox76 requested a review from egilmorez as a code owner September 28, 2021 00:15
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 28, 2021

Binary Size Report

Affected SDKs

No changes between base commit (49b0406) and head commit (4ad33d4).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 28, 2021

Size Analysis Report

Affected Products

No changes between base commit (49b0406) and head commit (4ad33d4).

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Sep 28, 2021
@hsubox76 hsubox76 merged commit 2ad6ce8 into master Sep 28, 2021
@hsubox76 hsubox76 deleted the ch-changeset-fix-4 branch September 28, 2021 18:27
@firebase firebase locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants