Fetch API missing support handling #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obile Safari related to worker support. Most of these are attributed to lack of support for fetch related APIs even when web workers are still supported. In that case we throw an operation not supported in environment error on operations that require http requests.
bojeil-google
requested review from
jshcrowthe,
TMSCH and
wti806
as code owners
wti806
approved these changes
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vague errors thrown in older browsers such as IE10/11 and iOS mobile Safari related to worker support.
Most of these are attributed to lack of support for fetch related APIs even when web workers are still supported.
In that case we throw an operation not supported in environment error on operations that require http requests.
Also adds missing dependency on firebase-functions required for demo app.