Remove departing team members from codeowners #5820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Binary Size ReportAffected SDKsNo changes between base commit (0db840a) and head commit (0e64d75). Test Logs
|
Size Analysis Report |
allspain
approved these changes
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove @Feiyang1 and @hiranya911 from CODEOWNERS file. They are not removed from the comment under
@firebase/jssdk-global-approversbecause that's just a comment listing who is in that team, whose actual membership is managed elsewhere in Github.We can delay removing them from that team for now, and they'll still be able to approve requests if needed as part of the team, but won't get notifications for every PR. Will file a separate internal bug when the time comes to remove them from the jssdk-global-approvers team if needed.