Skip to content

Fix Firestore compile #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Fix Firestore compile #5869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acb9416
Fix Firestore compile
schmidt-sebastian Jan 7, 2022
1cd2c73
Format
schmidt-sebastian Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/util/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"build": "rollup -c",
"build:deps": "lerna run --scope @firebase/util --include-dependencies build",
"dev": "rollup -c -w",
"prettier": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
"test": "run-p lint test:all",
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
"test:all": "run-p test:browser test:node",
Expand Down Expand Up @@ -57,4 +58,4 @@
],
"reportDir": "./coverage/node"
}
}
}
2 changes: 1 addition & 1 deletion packages/util/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export interface ErrorData {
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error#Custom_Error_Types
export class FirebaseError extends Error {
/** The custom name for all FirebaseErrors. */
readonly name = ERROR_NAME;
readonly name: string = ERROR_NAME;

constructor(
/** The error code for this error. */
Expand Down