Skip to content

Add cordova and rn export paths to auth #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Add cordova and rn export paths to auth #5904

merged 1 commit into from
Jan 20, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 20, 2022

Seems like it needs the exact file path in "exports". See the firebase/messaging/sw path for the same pattern:

That one is split into 3 because it has a Node version.

Fixes #5878

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2022

⚠️ No Changeset found

Latest commit: bd37cb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase

    TypeBase (c5d8f65)Merge (b2023df)Diff
    firebase-auth-cordova.js91 B462 kB+462 kB (+508048.4%)
    firebase-auth-react-native.js101 B484 kB+484 kB (+479364.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xvK0zcSVBI.html

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit 17165a8 into master Jan 20, 2022
@hsubox76 hsubox76 deleted the ch-cordova branch January 20, 2022 16:46
@firebase firebase locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular build error using firebase, when importing firebase/auth/cordova
3 participants