Port IndexState and IndexOffset #5916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/fieldindex
branch
from
bc196ab to
993228f
Compare
|
thebrianchen
approved these changes
Jan 27, 2022
| return primitiveComparator(left.kind, right.kind); | ||
| } | ||
|
|
||
| /** Stores the "high water mark" that indicates how updated the Index is for the current user. */ |
| (options.fields ?? []).map( | ||
| entry => new IndexSegment(field(entry[0]), entry[1]) | ||
| ), | ||
| new IndexState(-1, options.offset ?? IndexOffset.min()) |
There was a problem hiding this comment.
nit: pref using global const for -1
| } | ||
|
|
||
| for ( | ||
| let i = 0; |
There was a problem hiding this comment.
optional: if the left and right segments don't match in length, we can exit early rather than comparing, but i can also see how this code is less verbose
There was a problem hiding this comment.
That works for equals, but not here since "b,c" sorts after "a".
| } | ||
|
|
||
| /** Creates a new offset based on the provided document. */ | ||
| export function newIndexOffsetFromDocument(document: Document): IndexOffset { |
There was a problem hiding this comment.
Just double checking that you plan on adding another method to create a new index offset with a specified largest batch id.
There was a problem hiding this comment.
The equivalent for Web is just calling the constructor of IndexOffset.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.