Skip to content

Fix Proto loading for Node tests #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 22, 2022

Not sure why the CI and my previous runs passed, but now my local Node tests are failing. This fixes the error for me. The new files are imported by firestore.proto

Not sure why, but my local Node tests are failing. This fixes the for me. The new files are imported by firestore.proto
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2022

⚠️ No Changeset found

Latest commit: 397d08e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian merged commit 51b376c into master Jan 28, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixprotos branch January 28, 2022 00:26
@firebase firebase locked and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants