Skip to content

Fix compilation for MemoryRemoteDocumentCache #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2022
Merged

Fix compilation for MemoryRemoteDocumentCache #5950

merged 3 commits into from
Jan 31, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 28, 2022 •
edited
Loading

... why does this not break the build!? No one knows.

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 16305db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (6555aa7)Merge (a65ab65)Diff
    browser229 kB229 kB+18 B (+0.0%)
    esm5286 kB286 kB+18 B (+0.0%)
    main456 kB456 kB+44 B (+0.0%)
    module229 kB229 kB+18 B (+0.0%)
    react-native229 kB229 kB+18 B (+0.0%)

  • bundle

    TypeBase (6555aa7)Merge (a65ab65)Diff
    firestore (Persistence)230 kB230 kB+18 B (+0.0%)
    firestore (Query Cursors)189 kB189 kB+9 B (+0.0%)
    firestore (Query)190 kB190 kB+9 B (+0.0%)
    firestore (Read data once)179 kB179 kB+9 B (+0.0%)
    firestore (Realtime updates)181 kB181 kB+9 B (+0.0%)
    firestore (Transaction)163 kB163 kB+9 B (+0.0%)
    firestore (Write data)163 kB163 kB+9 B (+0.0%)

  • firebase

    TypeBase (6555aa7)Merge (a65ab65)Diff
    firebase-compat.js754 kB754 kB+18 B (+0.0%)
    firebase-firestore-compat.js281 kB281 kB+18 B (+0.0%)
    firebase-firestore.js775 kB775 kB+256 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5uW9XmdbgI.html

@schmidt-sebastian schmidt-sebastian removed the request for review from wu-hui January 28, 2022 23:33
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • addDoc

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size106 kB106 kB+8 B (+0.0%)
      size-with-ext-deps156 kB156 kB+9 B (+0.0%)

    • deleteDoc

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size96.8 kB96.9 kB+8 B (+0.0%)
      size-with-ext-deps147 kB147 kB+9 B (+0.0%)

    • disableNetwork

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size85.5 kB85.5 kB+8 B (+0.0%)
      size-with-ext-deps135 kB135 kB+9 B (+0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size142 kB142 kB+18 B (+0.0%)
      size-with-ext-deps192 kB192 kB+18 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size173 kB173 kB+18 B (+0.0%)
      size-with-ext-deps223 kB223 kB+18 B (+0.0%)

    • enableNetwork

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size85.5 kB85.5 kB+8 B (+0.0%)
      size-with-ext-deps135 kB135 kB+9 B (+0.0%)

    • executeWrite

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size96.0 kB96.0 kB+8 B (+0.0%)
      size-with-ext-deps146 kB146 kB+9 B (+0.0%)

    • getDoc

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size122 kB122 kB+8 B (+0.0%)
      size-with-ext-deps171 kB172 kB+9 B (+0.0%)

    • getDocFromCache

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size78.6 kB78.6 kB+8 B (+0.0%)
      size-with-ext-deps127 kB127 kB+9 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size122 kB122 kB+8 B (+0.0%)
      size-with-ext-deps172 kB172 kB+9 B (+0.0%)

    • getDocs

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size123 kB123 kB+8 B (+0.0%)
      size-with-ext-deps173 kB173 kB+9 B (+0.0%)

    • getDocsFromCache

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size85.9 kB85.9 kB+8 B (+0.0%)
      size-with-ext-deps135 kB135 kB+9 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size123 kB123 kB+8 B (+0.0%)
      size-with-ext-deps173 kB173 kB+9 B (+0.0%)

    • loadBundle

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size94.3 kB94.3 kB+8 B (+0.0%)
      size-with-ext-deps144 kB144 kB+9 B (+0.0%)

    • namedQuery

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size72.1 kB72.1 kB+8 B (+0.0%)
      size-with-ext-deps121 kB121 kB+9 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size124 kB124 kB+8 B (+0.0%)
      size-with-ext-deps174 kB174 kB+9 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size114 kB114 kB+8 B (+0.0%)
      size-with-ext-deps163 kB163 kB+9 B (+0.0%)

    • runTransaction

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size106 kB106 kB+8 B (+0.0%)
      size-with-ext-deps156 kB156 kB+9 B (+0.0%)

    • setDoc

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size105 kB105 kB+8 B (+0.0%)
      size-with-ext-deps155 kB155 kB+9 B (+0.0%)

    • updateDoc

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size106 kB106 kB+8 B (+0.0%)
      size-with-ext-deps155 kB155 kB+9 B (+0.0%)

    • waitForPendingWrites

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size85.9 kB86.0 kB+8 B (+0.0%)
      size-with-ext-deps136 kB136 kB+9 B (+0.0%)

    • writeBatch

      Size

      TypeBase (6555aa7)Merge (a65ab65)Diff
      size107 kB107 kB+8 B (+0.0%)
      size-with-ext-deps157 kB157 kB+9 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u18P9h4r7O.html

wu-hui
wu-hui approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooh, weird.

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Jan 31, 2022
@schmidt-sebastian schmidt-sebastian merged commit aaeab08 into master Jan 31, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixcompile branch January 31, 2022 18:11
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui