Skip to content

Enable abortOnError for Firestore #5955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

⚠️ No Changeset found

Latest commit: f1cad1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might have been put in place while we had v8 and exp packages simultaneously, to ignore some of the unavoidable errors caused by that, so maybe we can start removing this across the board.

@schmidt-sebastian schmidt-sebastian merged commit dd86989 into master Jan 31, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/abortonerror branch January 31, 2022 22:02
@firebase firebase locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants