Skip to content

Updates the @firebase/webchannel-wrapper Version #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2018
Merged

Updates the @firebase/webchannel-wrapper Version #596

merged 2 commits into from
Mar 26, 2018

Conversation

jshcrowthe
Copy link
Contributor

This updates the closure-builder dependency in the @firebase/webchannel-wrapper package. This should help to address some of the perf issues we've been seeing.

@jshcrowthe jshcrowthe requested a review from mikelehen March 26, 2018 18:49
mikelehen
mikelehen approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jshcrowthe jshcrowthe merged commit faa54d8 into master Mar 26, 2018
@jshcrowthe jshcrowthe deleted the deps branch April 16, 2018 21:57
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@wilhuff wilhuff Awaiting requested review from wilhuff

Assignees

@mikelehen mikelehen

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jshcrowthe @mikelehen @google-oss-bot