Skip to content

Port IndexManager APIs #5960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

Port IndexManager APIs #5960

merged 3 commits into from
Feb 2, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 1, 2022 •
edited
Loading

This PR ports the new APIs for IndexManager.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e2d44d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian marked this pull request as ready for review February 1, 2022 22:43
@schmidt-sebastian schmidt-sebastian changed the title Port IndexManager Port IndexManager APIs Feb 1, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 1, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (4cec423)Merge (dccbd4a)Diff
    browser230 kB231 kB+771 B (+0.3%)
    esm5287 kB288 kB+1.12 kB (+0.4%)
    main457 kB459 kB+1.33 kB (+0.3%)
    module230 kB231 kB+771 B (+0.3%)
    react-native230 kB231 kB+771 B (+0.3%)

  • bundle

    TypeBase (4cec423)Merge (dccbd4a)Diff
    firestore (Persistence)231 kB231 kB+744 B (+0.3%)
    firestore (Query Cursors)189 kB190 kB+368 B (+0.2%)
    firestore (Query)190 kB191 kB+368 B (+0.2%)
    firestore (Read data once)179 kB179 kB+368 B (+0.2%)
    firestore (Realtime updates)181 kB181 kB+368 B (+0.2%)
    firestore (Transaction)163 kB164 kB+376 B (+0.2%)
    firestore (Write data)163 kB163 kB+376 B (+0.2%)

  • firebase

    TypeBase (4cec423)Merge (dccbd4a)Diff
    firebase-compat.js754 kB755 kB+744 B (+0.1%)
    firebase-firestore-compat.js282 kB282 kB+744 B (+0.3%)
    firebase-firestore.js778 kB780 kB+1.97 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oGM0HlLI0i.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 1, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (178,861 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8C7VzLCRF0.html

wu-hui
wu-hui approved these changes Feb 2, 2022
View reviewed changes
packages/firestore/src/local/index_manager.ts Outdated
/**
* Adds a field path index.
*
* Values for this index are persisted asynchronously. The index will only be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is referring to backfill right? If so, we should probably give a high level explanation of backfilling, instead of saying persisted async.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved comment.

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 2, 2022
@schmidt-sebastian schmidt-sebastian merged commit e8972ef into master Feb 2, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/indexmanager branch February 2, 2022 18:34
@firebase firebase locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui