Skip to content

Fix documentation #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fix documentation #5965

merged 2 commits into from
Feb 2, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 2, 2022

Errors caught in review when generating new docs pages. See internal cl/425742150

api-documenter doesn't allow referencing members of an enum, causing there to just be a blank space in the documentation text where {@link FactorId.PHONE} should be, so I moved the .PHONE out of the link.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

⚠️ No Changeset found

Latest commit: f1b4558

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit 00916e7 into master Feb 2, 2022
@hsubox76 hsubox76 deleted the ch-docfix branch February 2, 2022 20:27
@firebase firebase locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants