Update console.build.js to set a value on window #5979
Conversation
|
|
Hi, can you provide some context for this change? Is this a request from the Console team? |
|
Hello, for context please see the email thread "Eval in firestore_web_sdk". |
|
|
||
| async function build() { | ||
| const es5Bundle = await rollup.rollup(es5InputOptions); | ||
| const { | ||
| output: [{ code }] | ||
| } = await es5Bundle.generate(es5OutputOptions); | ||
|
|
||
| const output = `${PREFIX}${JSON.stringify(String(code))}${POSTFIX}`; | ||
| const output = `${String(code)}${POSTFIX}`; |
There was a problem hiding this comment.
I think that you need a newline or at least whitespace before ${POSTFIX} in order to match the code change in the CL. I guess the code always ends with a ; so it's probably okay either way, but just in case.
There was a problem hiding this comment.
Through experimentation, I am seeing that code ends with both a semicolon and newline. Do you think we should add another one?
There was a problem hiding this comment.
It's probably fine, I guess there was no newline in the previous version because it was JSON.stringified.
This change updates the console.build.js script that is used internally at Google to build the Firestore SDK.
Use of
evalis removed and instead the code is exported using the globalwindow.