IndexeddbIndexManager.updateEntries() #5999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
schmidt-sebastian
force-pushed
the
mrschmidt/updateindexentries
branch
from
4eca730 to
ea903a6
Compare
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (641,979 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
wu-hui
reviewed
Feb 14, 2022
| @@ -269,8 +320,176 @@ export class IndexedDbIndexManager implements IndexManager { | |||
| transaction: PersistenceTransaction, | |||
| documents: DocumentMap | |||
| ): PersistencePromise<void> { | |||
| // TODO(indexing): Implement | |||
| return PersistencePromise.resolve(); | |||
| const memoizedIndexes = new Map<string, FieldIndex[]>(); | |||
There was a problem hiding this comment.
Looks like Android calls getFieldIndexes and have the memoization optimization done there? Is there a reason for the deviation?
There was a problem hiding this comment.
Added comment:
// Porting Note: `getFieldIndexes()` on Web does not cache index lookups as
// it could be used across different IndexedDB transactions. As any cached
// data might invalidated by other multi-tab clients, we can only trust data
// within a single IndexedDB transaction. We therefore add a cache here.
wu-hui
approved these changes
Feb 15, 2022
| @@ -269,8 +320,176 @@ export class IndexedDbIndexManager implements IndexManager { | |||
| transaction: PersistenceTransaction, | |||
| documents: DocumentMap | |||
| ): PersistencePromise<void> { | |||
| // TODO(indexing): Implement | |||
| return PersistencePromise.resolve(); | |||
| const memoizedIndexes = new Map<string, FieldIndex[]>(); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the
updateEntriescode from Android.