Skip to content

Group firestore-compat and auth-compat properly in test config #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

hsubox76
Copy link
Contributor

firestore-compat belongs with firestore, auth-compat belongs with auth in the separated test configs for the "test-changed" script. Made sure to exclude them from the "core" config as well.

@hsubox76 hsubox76 requested a review from allspain as a code owner February 11, 2022 18:56
@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2022

⚠️ No Changeset found

Latest commit: f7b5286

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@allspain allspain assigned hsubox76 and unassigned allspain Feb 14, 2022
@hsubox76 hsubox76 merged commit ea98957 into master Feb 15, 2022
@hsubox76 hsubox76 deleted the ch-chromedriver branch February 15, 2022 01:38
@firebase firebase locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants