Skip to content

Integrate Document Overlay with the SDK. #6012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Integrate Document Overlay with the SDK. #6012

wants to merge 15 commits into from

Conversation

ehsannas
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5ed48fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas ehsannas marked this pull request as draft February 15, 2022 22:31
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 16, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (3a8d4c1)Merge (80c870e)Diff
    browser244 kB247 kB+3.03 kB (+1.2%)
    esm5304 kB307 kB+3.33 kB (+1.1%)
    main486 kB493 kB+7.33 kB (+1.5%)
    module244 kB247 kB+3.03 kB (+1.2%)
    react-native244 kB247 kB+3.03 kB (+1.2%)

  • @firebase/firestore-lite

    TypeBase (3a8d4c1)Merge (80c870e)Diff
    browser73.0 kB73.0 kB+55 B (+0.1%)
    esm586.4 kB86.4 kB+59 B (+0.1%)
    main125 kB126 kB+75 B (+0.1%)
    module73.0 kB73.0 kB+55 B (+0.1%)
    react-native73.2 kB73.2 kB+55 B (+0.1%)

  • bundle

    12 size changes

    TypeBase (3a8d4c1)Merge (80c870e)Diff
    firestore (Persistence)245 kB248 kB+2.95 kB (+1.2%)
    firestore (Query Cursors)192 kB195 kB+3.44 kB (+1.8%)
    firestore (Query)193 kB196 kB+3.44 kB (+1.8%)
    firestore (Read data once)181 kB185 kB+3.44 kB (+1.9%)
    firestore (Realtime updates)183 kB187 kB+3.44 kB (+1.9%)
    firestore (Transaction)166 kB169 kB+2.62 kB (+1.6%)
    firestore (Write data)165 kB168 kB+3.01 kB (+1.8%)
    firestore-lite (Query Cursors)56.8 kB56.9 kB+22 B (+0.0%)
    firestore-lite (Query)59.9 kB59.9 kB+22 B (+0.0%)
    firestore-lite (Read data once)44.4 kB44.4 kB+22 B (+0.0%)
    firestore-lite (Transaction)61.7 kB61.8 kB+55 B (+0.1%)
    firestore-lite (Write data)47.2 kB47.2 kB+33 B (+0.1%)

  • firebase

    TypeBase (3a8d4c1)Merge (80c870e)Diff
    firebase-compat.js769 kB772 kB+2.97 kB (+0.4%)
    firebase-firestore-compat.js296 kB299 kB+2.97 kB (+1.0%)
    firebase-firestore-lite.js250 kB250 kB+88 B (+0.0%)
    firebase-firestore.js812 kB820 kB+8.21 kB (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4q8BN217sv.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 16, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (518,354 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YWRG991pMA.html

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@ehsannas
Copy link
Contributor Author

ehsannas commented Mar 8, 2022

Closing this in favor of #6054 which has other fixes and is rebased against tip of tree.

@ehsannas ehsannas closed this Mar 8, 2022
@firebase firebase locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @google-oss-bot