Skip to content

Make getNextCollectionGroupToUpdate() deterministic #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

⚠️ No Changeset found

Latest commit: f7a5883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 24, 2022
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (091e867)Merge (c2298a2)Diff
    browser251 kB251 kB+65 B (+0.0%)
    esm5311 kB311 kB+54 B (+0.0%)
    main500 kB500 kB+88 B (+0.0%)
    module251 kB251 kB+65 B (+0.0%)
    react-native251 kB251 kB+65 B (+0.0%)
  • bundle

    TypeBase (091e867)Merge (c2298a2)Diff
    firestore (Persistence)252 kB252 kB+65 B (+0.0%)
  • firebase

    TypeBase (091e867)Merge (c2298a2)Diff
    firebase-compat.js775 kB775 kB+62 B (+0.0%)
    firebase-firestore-compat.js302 kB302 kB+62 B (+0.0%)
    firebase-firestore.js835 kB836 kB+101 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KfUogXo92j.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (091e867)Merge (c2298a2)Diff
      size164 kB164 kB+64 B (+0.0%)
      size-with-ext-deps214 kB214 kB+65 B (+0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (091e867)Merge (c2298a2)Diff
      size195 kB195 kB+64 B (+0.0%)
      size-with-ext-deps245 kB246 kB+65 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LrZkRHbgD1.html

@schmidt-sebastian schmidt-sebastian merged commit 2b98b28 into master Feb 24, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/deterministic branch February 24, 2022 21:58
@firebase firebase locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants