Skip to content

Update App Check to v1 from v1beta #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Update App Check to v1 from v1beta #6136

merged 5 commits into from
Apr 15, 2022

Conversation

dwyfrequency
Copy link
Contributor

For both reCAPTCHA v3 and reCAPTCHA Enterprise:

  1. Updated URL to exchange for an App Check token
  2. Updated the response JSON object containing the FAC token

@dwyfrequency dwyfrequency requested a review from hsubox76 as a code owner April 11, 2022 22:18
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

🦋 Changeset detected

Latest commit: 16c966c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app-check Patch
@firebase/app-check-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2022

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (e9e5f6b)Merge (56005ca)Diff
    browser25.2 kB25.2 kB-10 B (-0.0%)
    esm529.8 kB29.8 kB-10 B (-0.0%)
    main31.0 kB31.0 kB-10 B (-0.0%)
    module25.2 kB25.2 kB-10 B (-0.0%)
  • bundle

    TypeBase (e9e5f6b)Merge (56005ca)Diff
    app-check (CustomProvider)33.7 kB33.7 kB-15 B (-0.0%)
    app-check (ReCaptchaEnterpriseProvider)35.9 kB35.9 kB-15 B (-0.0%)
    app-check (ReCaptchaV3Provider)35.9 kB35.8 kB-10 B (-0.0%)
  • firebase

    TypeBase (e9e5f6b)Merge (56005ca)Diff
    firebase-app-check-compat.js22.7 kB22.7 kB-10 B (-0.0%)
    firebase-app-check.js90.1 kB90.0 kB-10 B (-0.0%)
    firebase-compat.js778 kB778 kB-10 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ggJd5gBE1e.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2022

Size Analysis Report 1

Affected Products

  • @firebase/app-check

    • ReCaptchaEnterpriseProvider

      Size

      TypeBase (e9e5f6b)Merge (56005ca)Diff
      size10.9 kB10.9 kB-15 B (-0.1%)
      size-with-ext-deps26.6 kB26.5 kB-15 B (-0.1%)
    • ReCaptchaV3Provider

      Size

      TypeBase (e9e5f6b)Merge (56005ca)Diff
      size10.9 kB10.9 kB-10 B (-0.1%)
      size-with-ext-deps26.5 kB26.5 kB-10 B (-0.0%)
    • initializeAppCheck

      Size

      TypeBase (e9e5f6b)Merge (56005ca)Diff
      size11.0 kB11.0 kB-15 B (-0.1%)
      size-with-ext-deps26.8 kB26.8 kB-15 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jjYeHtXIXv.html

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, last step is to add a changeset. yarn changeset, then follow the prompts. It should automatically choose the @firebase/app-check package, just confirm. Say no to "major" and "minor" and it will accept it as a "patch" bump. Then just write a short description of the change (for the changelog, doesn't have to be too deep).

@dwyfrequency dwyfrequency requested a review from egilmorez as a code owner April 12, 2022 17:45
@dwyfrequency
Copy link
Contributor Author

Added the changeset for this PR

@dwyfrequency dwyfrequency merged commit 38da5d9 into master Apr 15, 2022
@dwyfrequency dwyfrequency deleted the appCheckToV1 branch April 15, 2022 19:20
@google-oss-bot google-oss-bot mentioned this pull request Apr 27, 2022
@hckhanh
Copy link

hckhanh commented Apr 30, 2022

Hi @dwyfrequency, I receive the error after upgrading to Firebase 9.7.0

I realized that it came from this api:

https://content-firebaseappcheck.googleapis.com/v1/projects/<project_id>/apps/<app_id>:exchangeRecaptchaV3Token?key=<api_key>

{
  "error": {
    "code": 404,
    "message": "Method not found.",
    "status": "NOT_FOUND"
  }
}

@firebase firebase locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants