Fix a bug that was introduced in PR: #591 #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firestore tests are failing - FYI. |
gauntface
approved these changes
Apr 2, 2018
| @@ -80,6 +80,8 @@ export default class ControllerInterface { | |||
|
|
|||
| const swReg = await this.getSWRegistration_(); | |||
| const publicVapidKey = await this.getPublicVapidKey_(); | |||
| // If there didn't exist one, this call will subscribe a new | |||
| // push subscription. | |||
There was a problem hiding this comment.
Re-word to:
If a PushSubscription exists it's returned, otherwise a new subscription is generated and returned.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically when the permissions are revoked and restored, do not unsubscribe from the PushSubscription, as we're using a brand new one.
Just remove the token from DB and from FCM server DB.