Skip to content

Support plumbing for partial index execution #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2022
Merged

Support plumbing for partial index execution #6143

merged 2 commits into from
Apr 14, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

Port of firebase/firebase-android-sdk#3583. The Query engine part of the PR is not ported as we do not yet have the Query Engine changes that require this change.

@schmidt-sebastian
Support plumbing for partial index execution
f0f42d2 
Port of firebase/firebase-android-sdk#3583. The Query engine part of the PR is not ported as we do not yet have the Query Engine changes that require this change.
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: fdeea8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (05dc9d6)Merge (8dd5a3f)Diff
    browser252 kB252 kB+303 B (+0.1%)
    esm5313 kB313 kB+370 B (+0.1%)
    main503 kB504 kB+681 B (+0.1%)
    module252 kB252 kB+303 B (+0.1%)
    react-native252 kB252 kB+303 B (+0.1%)

  • bundle

    TypeBase (05dc9d6)Merge (8dd5a3f)Diff
    firestore (Persistence)262 kB262 kB+303 B (+0.1%)
    firestore (Query Cursors)202 kB202 kB-4 B (-0.0%)
    firestore (Query)203 kB203 kB-4 B (-0.0%)
    firestore (Read data once)192 kB192 kB-4 B (-0.0%)
    firestore (Realtime updates)194 kB194 kB-4 B (-0.0%)
    firestore (Transaction)176 kB176 kB-4 B (-0.0%)
    firestore (Write data)176 kB176 kB-4 B (-0.0%)

  • firebase

    TypeBase (05dc9d6)Merge (8dd5a3f)Diff
    firebase-compat.js779 kB779 kB+304 B (+0.0%)
    firebase-firestore-compat.js303 kB304 kB+304 B (+0.1%)
    firebase-firestore.js821 kB822 kB+1.40 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PwgZMPyfMA.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (260,754 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IWbwvfrS05.html

ehsannas
ehsannas reviewed Apr 13, 2022
View reviewed changes
@schmidt-sebastian schmidt-sebastian merged commit 15409a7 into master Apr 14, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/indexmanager branch April 14, 2022 16:23
@firebase firebase locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @ehsannas