Normalize line endings for markdown files checked into git #6290

dwyfrequency · 2022-05-23T19:37:39Z

Use https://git-scm.com/docs/gitattributes to normalize line endings for markdown files checked into git. We had issues in the past where files with different line endings would be checked in and the diff would show the entire file as changed. This will use the line endings specified for all markdown files checked in.

changeset-bot · 2022-05-23T19:37:41Z

⚠️ No Changeset found

Latest commit: 82f7e61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-05-23T19:57:11Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 18.9 kB ? (?)
esm5 ? 23.5 kB ? (?)
main ? 24.6 kB ? (?)
module ? 18.9 kB ? (?)
@firebase/analytics-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 2.57 kB ? (?)
esm5 ? 2.80 kB ? (?)
main ? 3.24 kB ? (?)
module ? 2.57 kB ? (?)
@firebase/api-documenter
Type Base (11d37ed) Merge (ffda3fd) Diff
main ? 3.95 kB ? (?)
@firebase/app
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 13.8 kB ? (?)
esm5 ? 18.0 kB ? (?)
main ? 19.0 kB ? (?)
module ? 13.8 kB ? (?)
@firebase/app-check
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 25.2 kB ? (?)
esm5 ? 29.8 kB ? (?)
main ? 31.0 kB ? (?)
module ? 25.2 kB ? (?)
@firebase/app-check-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 2.27 kB ? (?)
esm5 ? 2.48 kB ? (?)
main ? 2.94 kB ? (?)
module ? 2.27 kB ? (?)
@firebase/app-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 5.28 kB ? (?)
esm5 ? 6.13 kB ? (?)
lite ? 4.06 kB ? (?)
main ? 6.73 kB ? (?)
module ? 5.28 kB ? (?)
@firebase/auth-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 20.2 kB ? (?)
esm5 ? 27.0 kB ? (?)
main ? 29.6 kB ? (?)
module ? 20.2 kB ? (?)
@firebase/auth/cordova
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 183 kB ? (?)
module ? 183 kB ? (?)
@firebase/auth/internal
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 166 kB ? (?)
esm5 ? 216 kB ? (?)
main ? 183 kB ? (?)
module ? 166 kB ? (?)
@firebase/auth/react-native
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 168 kB ? (?)
module ? 168 kB ? (?)
@firebase/component
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 6.54 kB ? (?)
esm5 ? 8.61 kB ? (?)
main ? 8.99 kB ? (?)
module ? 6.54 kB ? (?)
@firebase/database
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 248 kB ? (?)
esm5 ? 276 kB ? (?)
main ? 281 kB ? (?)
module ? 248 kB ? (?)
@firebase/database-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 18.0 kB ? (?)
esm5 ? 21.1 kB ? (?)
main ? 21.8 kB ? (?)
module ? 18.0 kB ? (?)
@firebase/database-compat/standalone
Type Base (11d37ed) Merge (ffda3fd) Diff
main ? 370 kB ? (?)
@firebase/firestore
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 257 kB ? (?)
esm5 ? 319 kB ? (?)
main ? 515 kB ? (?)
module ? 257 kB ? (?)
react-native ? 257 kB ? (?)
@firebase/firestore-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 20.5 kB ? (?)
esm5 ? 27.6 kB ? (?)
main ? 20.9 kB ? (?)
module ? 20.5 kB ? (?)
react-native ? 20.5 kB ? (?)
@firebase/firestore-lite
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 80.5 kB ? (?)
esm5 ? 96.2 kB ? (?)
main ? 135 kB ? (?)
module ? 80.5 kB ? (?)
react-native ? 80.7 kB ? (?)
@firebase/functions
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 9.39 kB ? (?)
esm5 ? 11.5 kB ? (?)
main ? 12.4 kB ? (?)
module ? 9.39 kB ? (?)
@firebase/functions-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 1.79 kB ? (?)
esm5 ? 1.98 kB ? (?)
main ? 2.34 kB ? (?)
module ? 1.79 kB ? (?)
@firebase/installations
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 17.8 kB ? (?)
esm5 ? 22.9 kB ? (?)
main ? 23.8 kB ? (?)
module ? 17.8 kB ? (?)
@firebase/installations-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 944 B ? (?)
esm5 ? 1.16 kB ? (?)
main ? 1.48 kB ? (?)
module ? 944 B ? (?)
@firebase/logger
Type Base (11d37ed) Merge (ffda3fd) Diff
esm5 ? 4.65 kB ? (?)
main ? 5.32 kB ? (?)
module ? 3.25 kB ? (?)
@firebase/messaging
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 20.8 kB ? (?)
esm5 ? 26.2 kB ? (?)
main ? 26.9 kB ? (?)
module ? 20.8 kB ? (?)
@firebase/messaging-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 2.08 kB ? (?)
esm5 ? 2.51 kB ? (?)
main ? 2.90 kB ? (?)
module ? 2.08 kB ? (?)
@firebase/messaging-sw
Type Base (11d37ed) Merge (ffda3fd) Diff
main ? 29.6 kB ? (?)
module ? 22.9 kB ? (?)
@firebase/performance
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 29.1 kB ? (?)
esm5 ? 30.8 kB ? (?)
main ? 31.2 kB ? (?)
module ? 29.1 kB ? (?)
@firebase/performance-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 1.10 kB ? (?)
esm5 ? 1.37 kB ? (?)
main ? 1.69 kB ? (?)
module ? 1.10 kB ? (?)
@firebase/remote-config
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 18.8 kB ? (?)
esm5 ? 23.7 kB ? (?)
main ? 24.9 kB ? (?)
module ? 18.8 kB ? (?)
@firebase/remote-config-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 1.85 kB ? (?)
esm5 ? 2.76 kB ? (?)
main ? 3.09 kB ? (?)
module ? 1.85 kB ? (?)
@firebase/rules-unit-testing
Type Base (11d37ed) Merge (ffda3fd) Diff
main ? 17.6 kB ? (?)
@firebase/storage
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 54.5 kB ? (?)
esm5 ? 60.5 kB ? (?)
main ? 57.3 kB ? (?)
module ? 54.5 kB ? (?)
@firebase/storage-compat
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 5.67 kB ? (?)
esm5 ? 8.41 kB ? (?)
main ? 8.82 kB ? (?)
module ? 5.67 kB ? (?)
@firebase/util
Type Base (11d37ed) Merge (ffda3fd) Diff
browser ? 20.5 kB ? (?)
esm5 ? 21.9 kB ? (?)
main ? 26.7 kB ? (?)
module ? 20.5 kB ? (?)
@firebase/webchannel-wrapper
Type Base (11d37ed) Merge (ffda3fd) Diff
esm5 ? 44.7 kB ? (?)
main ? 50.8 kB ? (?)
module ? 43.2 kB ? (?)

`bundle`

43 size changes

Type	Base (11d37ed)	Merge (`ffda3fd`)	Diff
analytics (logEvent)	?	41.5 kB	? (?)
app-check (CustomProvider)	?	35.2 kB	? (?)
app-check (ReCaptchaEnterpriseProvider)	?	37.4 kB	? (?)
app-check (ReCaptchaV3Provider)	?	37.4 kB	? (?)
auth (Anonymous)	?	66.0 kB	? (?)
auth (EmailAndPassword)	?	70.1 kB	? (?)
auth (GoogleFBTwitterGitHubPopup)	?	89.9 kB	? (?)
auth (GooglePopup)	?	89.7 kB	? (?)
auth (GoogleRedirect)	?	89.9 kB	? (?)
auth (Phone)	?	76.1 kB	? (?)
database (Append to a list of data)	?	145 kB	? (?)
database (Filtering data)	?	144 kB	? (?)
database (Listen for child events)	?	160 kB	? (?)
database (Listen for value events + Detach listeners)	?	160 kB	? (?)
database (Listen for value events)	?	160 kB	? (?)
database (Read data once)	?	152 kB	? (?)
database (Save data as transactions)	?	162 kB	? (?)
database (Sort data)	?	146 kB	? (?)
database (Write data)	?	144 kB	? (?)
firestore (Persistence)	?	269 kB	? (?)
firestore (Query Cursors)	?	208 kB	? (?)
firestore (Query)	?	209 kB	? (?)
firestore (Read data once)	?	197 kB	? (?)
firestore (Realtime updates)	?	200 kB	? (?)
firestore (Transaction)	?	181 kB	? (?)
firestore (Write data)	?	181 kB	? (?)
firestore-lite (Query Cursors)	?	67.8 kB	? (?)
firestore-lite (Query)	?	71.0 kB	? (?)
firestore-lite (Read data once)	?	55.4 kB	? (?)
firestore-lite (Transaction)	?	80.0 kB	? (?)
firestore-lite (Write data)	?	65.2 kB	? (?)
functions (call)	?	29.1 kB	? (?)
messaging (send + receive)	?	44.7 kB	? (?)
performance (trace)	?	49.5 kB	? (?)
remote-config (getAndFetch)	?	43.9 kB	? (?)
storage (getBytes)	?	37.4 kB	? (?)
storage (getDownloadURL)	?	39.5 kB	? (?)
storage (getMetadata)	?	39.0 kB	? (?)
storage (list + listAll)	?	38.4 kB	? (?)
storage (updateMetadata)	?	39.2 kB	? (?)
storage (uploadBytes)	?	43.8 kB	? (?)
storage (uploadBytesResumable)	?	53.2 kB	? (?)
storage (uploadString)	?	44.0 kB	? (?)

`firebase`

29 size changes

Type	Base (11d37ed)	Merge (`ffda3fd`)	Diff
firebase-analytics-compat.js	?	25.6 kB	? (?)
firebase-analytics.js	?	111 kB	? (?)
firebase-app-check-compat.js	?	22.7 kB	? (?)
firebase-app-check.js	?	90.0 kB	? (?)
firebase-app-compat.js	?	27.6 kB	? (?)
firebase-app.js	?	87.4 kB	? (?)
firebase-auth-compat.js	?	124 kB	? (?)
firebase-auth-cordova.js	?	472 kB	? (?)
firebase-auth-react-native.js	?	495 kB	? (?)
firebase-auth.js	?	417 kB	? (?)
firebase-compat.js	?	787 kB	? (?)
firebase-database-compat.js	?	166 kB	? (?)
firebase-database.js	?	604 kB	? (?)
firebase-firestore-compat.js	?	309 kB	? (?)
firebase-firestore-lite.js	?	267 kB	? (?)
firebase-firestore.js	?	837 kB	? (?)
firebase-functions-compat.js	?	8.12 kB	? (?)
firebase-functions.js	?	32.0 kB	? (?)
firebase-messaging-compat.js	?	37.5 kB	? (?)
firebase-messaging-sw.js	?	107 kB	? (?)
firebase-messaging.js	?	105 kB	? (?)
firebase-performance-compat.js	?	30.7 kB	? (?)
firebase-performance-standalone-compat.es2017.js	?	87.4 kB	? (?)
firebase-performance-standalone-compat.js	?	65.3 kB	? (?)
firebase-performance.js	?	123 kB	? (?)
firebase-remote-config-compat.js	?	27.1 kB	? (?)
firebase-remote-config.js	?	112 kB	? (?)
firebase-storage-compat.js	?	38.2 kB	? (?)
firebase-storage.js	?	146 kB	? (?)

functions
Type Base (11d37ed) Merge (ffda3fd) Diff
main ? 46 B ? (?)

Test Logs

Merge (ffda3fd): https://github.com/firebase/firebase-js-sdk/actions/runs/2373535478

https://storage.googleapis.com/firebase-sdk-metric-reports/9Tim6hwV5m.html

google-oss-bot · 2022-05-23T20:13:08Z

Size Analysis Report ¹

Affected Products

No changes between base commit (11d37ed) and merge commit (ffda3fd).

Test Logs

Base (11d37ed): https://github.com/firebase/firebase-js-sdk/actions/runs/2373350452
Merge (ffda3fd): https://github.com/firebase/firebase-js-sdk/actions/runs/2373535478

https://storage.googleapis.com/firebase-sdk-metric-reports/EWX2IZVnck.html

Normalize line endings for markdown files checked into git

82f7e61

dwyfrequency marked this pull request as ready for review May 23, 2022 20:43

dwyfrequency requested review from allspain and hsubox76 as code owners May 23, 2022 20:43

hsubox76 approved these changes May 23, 2022

View reviewed changes

dwyfrequency merged commit af7a182 into master May 23, 2022

dwyfrequency deleted the standardLineEndings branch May 23, 2022 22:06

firebase locked and limited conversation to collaborators Jun 23, 2022

Normalize line endings for markdown files checked into git #6290

Normalize line endings for markdown files checked into git #6290

Uh oh!

Conversation

dwyfrequency commented May 23, 2022

Uh oh!

changeset-bot bot commented May 23, 2022

⚠️ No Changeset found

Uh oh!

google-oss-bot commented May 23, 2022

Size Report 1

Affected Products

@firebase/analytics

@firebase/analytics-compat

@firebase/api-documenter

@firebase/app

@firebase/app-check

@firebase/app-check-compat

@firebase/app-compat

@firebase/auth-compat

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

@firebase/component

@firebase/database

@firebase/database-compat

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-compat

@firebase/firestore-lite

@firebase/functions

@firebase/functions-compat

@firebase/installations

@firebase/installations-compat

@firebase/logger

@firebase/messaging

@firebase/messaging-compat

@firebase/messaging-sw

@firebase/performance

@firebase/performance-compat

@firebase/remote-config

@firebase/remote-config-compat

@firebase/rules-unit-testing

@firebase/storage

@firebase/storage-compat

@firebase/util

@firebase/webchannel-wrapper

bundle

firebase

functions

Test Logs

Uh oh!

google-oss-bot commented May 23, 2022

Size Analysis Report 1

Affected Products

Test Logs

Uh oh!

Uh oh!

Size Report ¹

`@firebase/analytics`

`@firebase/analytics-compat`

`@firebase/api-documenter`

`@firebase/app`

`@firebase/app-check`

`@firebase/app-check-compat`

`@firebase/app-compat`

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/component`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/functions-compat`

`@firebase/installations`

`@firebase/installations-compat`

`@firebase/logger`

`@firebase/messaging`

`@firebase/messaging-compat`

`@firebase/messaging-sw`

`@firebase/performance`

`@firebase/performance-compat`

`@firebase/remote-config`

`@firebase/remote-config-compat`

`@firebase/rules-unit-testing`

`@firebase/storage`

`@firebase/storage-compat`

`@firebase/util`

`@firebase/webchannel-wrapper`

`bundle`

`firebase`

`functions`

Size Analysis Report ¹