Update release script with skipPrompts option #6294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dwyfrequency
approved these changes
May 24, 2022
| @@ -116,6 +103,19 @@ jobs: | |||
| NPM_TOKEN_APP_CHECK_COMPAT: ${{ secrets.NPM_TOKEN_APP_CHECK_COMPAT }} | |||
| NPM_TOKEN_API_DOCUMENTER: ${{ secrets.NPM_TOKEN_API_DOCUMENTER }} | |||
| CI: true | |||
| - name: Get release version | |||
| id: get-version | |||
| # STAGING_VERSION = version with staging hash, e.g. 1.2.3-20430523 | |||
There was a problem hiding this comment.
Do you want to keep these comments in here?
There was a problem hiding this comment.
Yep! So we know what those variables are supposed to be.
lahirumaramba
approved these changes
May 24, 2022
Size Report 1Affected ProductsNo changes between base commit (36dbcc3) and merge commit (20cb0ad).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (36dbcc3) and merge commit (20cb0ad).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run the release script in CI, it needs to skip the interactive prompts. Added a
skipPromptsflag to the command to allow this.Also the package.json isn't updated until after this script has run, so moved the step that gets the release version from the package.json to after the release script step.