Skip to content

Fix staging workflow #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 25, 2022
Merged

Fix staging workflow #6296

merged 17 commits into from
May 25, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 24, 2022

I actually tested this during development by calling the REST endpoint on this branch after each change, so it should all be working now.

  • E2E test uses latest Firebase CLI which just recently stopped supporting Node 12
  • Update release script so that if it is staging, and in CI, it will publish using the publishInCI() function, which runs the npm publish command on each package one by one, which lets us provide each package's specific wombat-dressing-room token. The simpler publish() function uses changeset publish which is more convenient but doesn't allow us to use wombat-dressing-room.
  • Delete release.yml. This used to be triggered on push to the release branch. It's redundant now as the same step is part of the release-staging.yml workflow.

TODO: Production publish script will have to find another way to grab the names of all the packages to publish since it doesn't run bumpVersionForStaging.

@hsubox76 hsubox76 requested a review from allspain as a code owner May 24, 2022 23:53
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

⚠️ No Changeset found

Latest commit: bec2a8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2022

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 71d5216 into master May 25, 2022
@hsubox76 hsubox76 deleted the ch-staging-fix-2 branch May 25, 2022 18:16
@firebase firebase locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants