-
Notifications
You must be signed in to change notification settings - Fork 946
Fix staging workflow #6296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix staging workflow #6296
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (4559c51) and merge commit (dc5644b).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (4559c51) and merge commit (dc5644b).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I actually tested this during development by calling the REST endpoint on this branch after each change, so it should all be working now.
publishInCI()
function, which runs thenpm publish
command on each package one by one, which lets us provide each package's specific wombat-dressing-room token. The simplerpublish()
function useschangeset publish
which is more convenient but doesn't allow us to use wombat-dressing-room.release.yml
. This used to be triggered on push to the release branch. It's redundant now as the same step is part of therelease-staging.yml
workflow.TODO: Production publish script will have to find another way to grab the names of all the packages to publish since it doesn't run
bumpVersionForStaging
.