Skip to content

Prod workflow: Fix logic for detecting published packages #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 27, 2022

  • If production release, pass all packages to publishToCI(), which will sort out which needs to be published.
  • Fix logic in publishToCI() to detect this.

Was able to test run successfully with some modifications (used --dryRun flag, skipped release tracker step)

@hsubox76 hsubox76 requested a review from allspain as a code owner May 27, 2022 01:29
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

⚠️ No Changeset found

Latest commit: 29a6463

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 27, 2022

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit cadc804 into master May 27, 2022
@hsubox76 hsubox76 deleted the ch-prod-release-2 branch May 27, 2022 17:27
@firebase firebase locked and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants