Run prettier on Auth #6529
Merged
Run prettier on Auth #6529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
avolkovi,
lisajian,
sam-gc,
yuchenshi and
dwyfrequency
as code owners
|
Size Report 1Affected ProductsNo changes between base commit (fcd4b8a) and merge commit (e9765ef).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (fcd4b8a) and merge commit (e9765ef).Test Logs |
hsubox76
force-pushed
the
ch-prettier-auth
branch
from
284f36f to
0bc6c9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/authwas included in the.prettierignorefile (should be the first file in this PR) ever since this SDK was ported to Github. I think it was because Auth was written in Closure at the time. Now that it's in Typescript like everything else, we should probably not be excluding it from prettier checks.Obviously there is a bit of a backlog after not running it for so long, so there are 102 changed files (all formatting changes - whitespace, indents, splitting params onto multiple lines, etc.)