-
Notifications
You must be signed in to change notification settings - Fork 946
Build Refactoring #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Refactoring #653
Conversation
"test": "run-p test:karma type-check lint", | ||
"test:karma": "karma start --single-run", | ||
"test:debug": "karma start --browsers=Chrome --auto-watch", | ||
"prepare": "gulp build", | ||
"prepare": "npm run build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be "yarn build"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were leveraging yarn
as a devDependency
here, yes. But since we can't assume yarn exists, sticking w/ NPM is functionally equivalent, and is safer.
Issues
There are several issues with the build process that I'd like to address:
Change Summary
The changes are broken down as follows:
@firebase/* Packages (not including the types packages)
main
,module
,browser
fields of eachpackage.json
to conform to rollup standardsgulp
to now referencerollup
(as pertinent)@firebase/*-types Packages
Results
Build Time
Before PR:
130.11s
After PR:
78.30s
Build Size
Before PR
After PR