Skip to content

Add IanWyszynski as codeowner for firebase-database #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add IanWyszynski as codeowner for firebase-database #6535

merged 1 commit into from
Aug 15, 2022

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Aug 15, 2022 •
edited
Loading

Adding myself as owner so I can grant approval on SDK PRs.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

⚠️ No Changeset found

Latest commit: 06fe4a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmwski jmwski requested review from jsdt, maneesht and lepatryk August 15, 2022 21:07
maneesht
maneesht approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (dc7574e) and merge commit (8ea903b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UlAH34RKUx.html

@jmwski jmwski assigned hsubox76 and unassigned jsdt Aug 15, 2022
@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (dc7574e) and merge commit (8ea903b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7OfRoujdtl.html

@jmwski jmwski merged commit 6f4ba25 into master Aug 15, 2022
@jmwski jmwski deleted the jw/codeowner branch August 15, 2022 21:47
@firebase firebase locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maneesht maneesht maneesht approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@jsdt jsdt Awaiting requested review from jsdt

@lepatryk lepatryk Awaiting requested review from lepatryk

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmwski @google-oss-bot @maneesht @hsubox76 @jsdt