Skip to content

Making public API changes to ensure that only QueryFilterConstraints can be passed to or(...) and and(...). #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Oct 26, 2022

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2022

⚠️ No Changeset found

Latest commit: b5a8fba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarkDuckworth MarkDuckworth changed the base branch from markduckworth/or-queries-pr-6 to markduckworth/or-queries-pr-5 August 24, 2022 22:34
@MarkDuckworth MarkDuckworth changed the base branch from markduckworth/or-queries-pr-5 to markduckworth/or-queries-pr-6 August 24, 2022 22:34
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Oct 6, 2022
Base automatically changed from markduckworth/or-queries-pr-6 to markduckworth/or-queries October 26, 2022 18:01
@MarkDuckworth MarkDuckworth marked this pull request as ready for review October 26, 2022 18:36
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (2a20810)Merge (2cac942)Diff
    browser269 kB269 kB+762 B (+0.3%)
    esm5333 kB334 kB+869 B (+0.3%)
    main538 kB539 kB+1.73 kB (+0.3%)
    module269 kB269 kB+762 B (+0.3%)
    react-native269 kB270 kB+762 B (+0.3%)
  • @firebase/firestore-lite

    TypeBase (2a20810)Merge (2cac942)Diff
    browser82.4 kB83.9 kB+1.55 kB (+1.9%)
    esm598.6 kB101 kB+1.98 kB (+2.0%)
    main139 kB142 kB+3.58 kB (+2.6%)
    module82.4 kB83.9 kB+1.55 kB (+1.9%)
    react-native82.6 kB84.1 kB+1.55 kB (+1.9%)
  • bundle

    TypeBase (2a20810)Merge (2cac942)Diff
    firestore (Query Cursors)211 kB212 kB+233 B (+0.1%)
    firestore (Query)213 kB213 kB+161 B (+0.1%)
    firestore-lite (Query Cursors)73.3 kB73.6 kB+233 B (+0.3%)
    firestore-lite (Query)72.7 kB72.9 kB+171 B (+0.2%)
  • firebase

    TypeBase (2a20810)Merge (2cac942)Diff
    firebase-compat.js742 kB742 kB+410 B (+0.1%)
    firebase-firestore-compat.js317 kB317 kB+410 B (+0.1%)
    firebase-firestore-lite.js87.7 kB89.3 kB+1.55 kB (+1.8%)
    firebase-firestore.js316 kB317 kB+762 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XLLsJciyDF.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2022

Size Analysis Report 1

This report is too large (205,601 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5lH0L31S8g.html

@MarkDuckworth MarkDuckworth merged commit 7c54b30 into markduckworth/or-queries Oct 26, 2022
@MarkDuckworth MarkDuckworth deleted the markduckworth/or-queries-pr-7 branch October 26, 2022 22:14
@firebase firebase locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants