Skip to content

Mila/count export aggregate to api #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 1, 2022
Merged

Mila/count export aggregate to api #6575

merged 4 commits into from
Sep 1, 2022

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Aug 31, 2022 •
edited
Loading

  • rename getAggregateFromServerDirect to getAggregate in lite-api
  • export aggregate query from lite-api to api
  • export and test getAggregateFromServerDirect in api

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 160071c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL changed the base branch from master to mila/count August 31, 2022 20:33
@milaGGL milaGGL requested review from dconeybe and removed request for dwyfrequency and hsubox76 August 31, 2022 20:33
dconeybe
dconeybe requested changes Sep 1, 2022
View reviewed changes
@milaGGL milaGGL requested a review from dconeybe September 1, 2022 16:58
dconeybe
dconeybe requested changes Sep 1, 2022
View reviewed changes
@milaGGL milaGGL merged commit 6da4f4f into mila/count Sep 1, 2022
@milaGGL milaGGL deleted the mila/count-export-aggregate-to-api branch September 1, 2022 19:57
@firebase firebase locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@dconeybe dconeybe

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @dconeybe