Markduckworth/or queries pr 9 #6755

MarkDuckworth · 2022-11-03T22:55:50Z

In expansion
Public API w/o deprecation

…arkduckworth/or-queries-pr-3

…se-js-sdk into markduckworth/or-queries-pr-4

…-pr-4

…rve OR queries from client-side index.

…r messages.

…pports implicit ANDs of filters.

…se-js-sdk into markduckworth/or-queries-pr-8

…tion of the existing query() function.

changeset-bot · 2022-11-03T22:55:54Z

⚠️ No Changeset found

Latest commit: 09046e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-11-03T23:22:53Z

Size Report ¹

Affected Products

`@firebase/firestore`

Type	Base (`7c54b30`)	Merge (`21c9bb6`)	Diff
browser	269 kB	270 kB	+506 B (+0.2%)
esm5	334 kB	334 kB	+556 B (+0.2%)
main	539 kB	540 kB	+1.04 kB (+0.2%)
module	269 kB	270 kB	+506 B (+0.2%)
react-native	270 kB	270 kB	+506 B (+0.2%)

`@firebase/firestore-lite`

Type	Base (`7c54b30`)	Merge (`21c9bb6`)	Diff
browser	83.9 kB	84.0 kB	+97 B (+0.1%)
esm5	101 kB	101 kB	+97 B (+0.1%)
main	142 kB	143 kB	+223 B (+0.2%)
module	83.9 kB	84.0 kB	+97 B (+0.1%)
react-native	84.1 kB	84.2 kB	+97 B (+0.1%)

`bundle`

Type	Base (`7c54b30`)	Merge (`21c9bb6`)	Diff
firestore (Persistence)	277 kB	277 kB	+410 B (+0.1%)
firestore (Query Cursors)	212 kB	212 kB	+116 B (+0.1%)
firestore (Query)	213 kB	213 kB	+95 B (+0.0%)
firestore-lite (Query Cursors)	73.6 kB	73.7 kB	+116 B (+0.2%)
firestore-lite (Query)	72.9 kB	73.0 kB	+95 B (+0.1%)

`firebase`

Type	Base (`7c54b30`)	Merge (`21c9bb6`)	Diff
firebase-compat.js	742 kB	743 kB	+495 B (+0.1%)
firebase-firestore-compat.js	317 kB	318 kB	+495 B (+0.2%)
firebase-firestore-lite.js	89.3 kB	89.4 kB	+97 B (+0.1%)
firebase-firestore.js	317 kB	317 kB	+507 B (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/3lROxE4uls.html

google-oss-bot · 2022-11-03T23:38:20Z

Size Analysis Report ¹

This report is too large (380,898 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/E31lZgOSyj.html

ehsannas

Looks good! Almost there

common/api-review/firestore-lite.api.md

common/api-review/firestore.api.md

packages/firestore/src/lite-api/query.ts

packages/firestore/test/unit/local/query_engine.test.ts

packages/firestore/test/integration/api/query.test.ts

packages/firestore/test/unit/local/query_engine.test.ts

…indexing into one test case that executes with both configurations.

MarkDuckworth added 30 commits June 24, 2022 14:53

Add composite filters. Port of firebase/firebase-android-sdk#3290

effced9

Cleanup: lint

eba3b84

Support encoding and decoding Composite Filters

33a0896

Formatting

9f6e216

Merge remote-tracking branch 'origin/markduckworth/or-queries' into m…

6556240

…arkduckworth/or-queries-pr-3

Fix issue with readonly array.

78a8900

WIP: serving results from index.

80fc05d

Perform DNF transform

8b6f05f

Cleanup and tests from firebase/firebase-android-sdk#3444

152fc18

Merge branch 'markduckworth/or-queries' of github.com:firebase/fireba…

8b0bfbd

…se-js-sdk into markduckworth/or-queries-pr-4

use index if we have composite filters

1c948cb

Merge branch 'markduckworth/or-queries' into markduckworth/or-queries…

2cad46c

…-pr-4

Fix bad import

266f7f6

Update the orderBy filtering mechanism for OR queries and steps to se…

c2d7cd2

…rve OR queries from client-side index.

Adding tests

41d0e29

Test for DNF computation.

90f7c50

Fix implementation of isFlatConjunction

ff52ecc

Adding integration tests for validation of composite queries.

dfda9f8

IndexDb manager tests for partial and full index.

9bc3336

Test query does not include documents with missing fields

d66abd4

Run prettier

e33263d

Add missing awaits

01c3487

Fixing argument validation for and . Updating tests for asserted erro…

7d56b57

…r messages.

Prettier

d01ff74

Removing duplicate test cases.

186fd92

Update proto with OR operator.

409b19c

Update protos with OR operator.

131f4be

Testing query with indexes

a514358

Add compile.sh to compile proto updates.

0ab215b

Adding new script to run browser tests against the emulator.

638b0ad

MarkDuckworth added 6 commits August 26, 2022 11:25

Add overloads for query and deprecate existing query overload that su…

77afd20

…pports implicit ANDs of filters.

Merge branch 'markduckworth/or-queries' of github.com:firebase/fireba…

3862740

…se-js-sdk into markduckworth/or-queries-pr-8

Implementing public API for OR queries that does not need the depreca…

efd98c7

…tion of the existing query() function.

Implementing 3rd iteration of the public API for OR queries.

94250da

Compute IN expansion.

ff0eede

Fix edge case a == 1 && a == 6

66bf749

Logic utils tests for in expansion.

968d133

MarkDuckworth assigned ehsannas Nov 3, 2022

MarkDuckworth marked this pull request as ready for review November 3, 2022 23:39

MarkDuckworth requested review from dwyfrequency and hsubox76 as code owners November 3, 2022 23:39

ehsannas reviewed Nov 8, 2022

View reviewed changes

MarkDuckworth added 4 commits November 8, 2022 11:32

Fixed rogue comment.

5f37954

Comment cleanup.

ab5cad2

Comment cleanup.

5fa9c76

Test refactoring.

9c6395b

MarkDuckworth requested a review from ehsannas November 8, 2022 23:20

ehsannas reviewed Nov 9, 2022

View reviewed changes

packages/firestore/test/unit/local/query_engine.test.ts Outdated Show resolved Hide resolved

packages/firestore/test/unit/local/query_engine.test.ts Outdated Show resolved Hide resolved

ehsannas assigned MarkDuckworth and unassigned ehsannas Nov 9, 2022

Collapsing duplicate tests that covered with and without client side …

09046e7

…indexing into one test case that executes with both configurations.

MarkDuckworth requested a review from ehsannas November 9, 2022 17:20

MarkDuckworth assigned ehsannas Nov 9, 2022

ehsannas approved these changes Nov 11, 2022

View reviewed changes

MarkDuckworth merged commit 89dac6c into markduckworth/or-queries Nov 11, 2022

MarkDuckworth deleted the markduckworth/or-queries-pr-9 branch November 11, 2022 18:01

firebase locked and limited conversation to collaborators Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Markduckworth/or queries pr 9 #6755

Markduckworth/or queries pr 9 #6755

Uh oh!

MarkDuckworth commented Nov 3, 2022 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 3, 2022 •

edited

Loading

Uh oh!

google-oss-bot commented Nov 3, 2022 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented Nov 3, 2022 •

edited

Loading

Uh oh!

ehsannas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Markduckworth/or queries pr 9 #6755

Markduckworth/or queries pr 9 #6755

Uh oh!

Conversation

MarkDuckworth commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

ehsannas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MarkDuckworth commented Nov 3, 2022 •

edited

Loading

changeset-bot bot commented Nov 3, 2022 •

edited

Loading

google-oss-bot commented Nov 3, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Nov 3, 2022 •

edited

Loading

Size Analysis Report ¹