-
Notifications
You must be signed in to change notification settings - Fork 945
Update proto to include BloomFilter #6780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
packages/firestore/src/protos/google/firestore/v1/bloom_filter.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// Copyright 2022 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package google.firestore.v1; | ||
|
||
option csharp_namespace = "Google.Cloud.Firestore.V1"; | ||
option go_package = "google.golang.org/genproto/googleapis/firestore/v1;firestore"; | ||
option java_multiple_files = true; | ||
option java_outer_classname = "BloomFilterProto"; | ||
option java_package = "com.google.firestore.v1"; | ||
option objc_class_prefix = "GCFS"; | ||
option php_namespace = "Google\\Cloud\\Firestore\\V1"; | ||
option ruby_package = "Google::Cloud::Firestore::V1"; | ||
|
||
// A sequence of bits, encoded in a byte array. | ||
// | ||
// Each byte in the `bitmap` byte array stores 8 bits of the sequence. The only | ||
// exception is the last byte, which may store 8 _or fewer_ bits. The `padding` | ||
// defines the number of bits of the last byte to be ignored as "padding". The | ||
// values of these "padding" bits are unspecified and must be ignored. | ||
// | ||
// To retrieve the first bit, bit 0, calculate: (bitmap[0] & 0x01) != 0. | ||
// To retrieve the second bit, bit 1, calculate: (bitmap[0] & 0x02) != 0. | ||
// To retrieve the third bit, bit 2, calculate: (bitmap[0] & 0x04) != 0. | ||
dconeybe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// To retrieve the fourth bit, bit 3, calculate: (bitmap[0] & 0x08) != 0. | ||
// To retrieve bit n, calculate: (bitmap[n / 8] & (0x01 << (n % 8))) != 0. | ||
// | ||
// The "size" of a `BitSequence` (the number of bits it contains) is calculated | ||
// by this formula: (bitmap.length * 8) - padding. | ||
message BitSequence { | ||
// The bytes that encode the bit sequence. | ||
// May have a length of zero. | ||
bytes bitmap = 1; | ||
|
||
// The number of bits of the last byte in `bitmap` to ignore as "padding". | ||
// If the length of `bitmap` is zero, then this value must be 0. | ||
// Otherwise, this value must be between 0 and 7, inclusive. | ||
int32 padding = 2; | ||
} | ||
|
||
// A bloom filter (https://en.wikipedia.org/wiki/Bloom_filter). | ||
// | ||
// The bloom filter hashes the entries with MD5 and treats the resulting 128-bit | ||
// hash as 2 distinct 64-bit hash values, interpreted as unsigned integers | ||
// using 2's complement encoding. | ||
// | ||
// These two hash values, named h1 and h2, are then used to compute the | ||
// `hash_count` hash values using the formula, starting at i=0: | ||
// | ||
// h(i) = h1 + (i * h2) | ||
// | ||
// These resulting values are then taken modulo the number of bits in the bloom | ||
// filter to get the bits of the bloom filter to test for the given entry. | ||
message BloomFilter { | ||
// The bloom filter data. | ||
BitSequence bits = 1; | ||
|
||
// The number of hashes used by the algorithm. | ||
int32 hash_count = 2; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.