OR queries more validation #6785

MarkDuckworth · 2022-11-12T00:40:10Z

OR queries more validation

…arkduckworth/or-queries-pr-3

…se-js-sdk into markduckworth/or-queries-pr-4

…-pr-4

…rve OR queries from client-side index.

…r messages.

…indexing into one test case that executes with both configurations.

…and(...), and or(...).

changeset-bot · 2022-11-12T00:40:13Z

⚠️ No Changeset found

Latest commit: bfaac63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…se-js-sdk into markduckworth/or-queries-pr-10

google-oss-bot · 2022-11-12T01:24:07Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (89dac6c) Merge (ba463fd) Diff
browser 270 kB 270 kB +380 B (+0.1%)
esm5 334 kB 335 kB +410 B (+0.1%)
main 540 kB 541 kB +611 B (+0.1%)
module 270 kB 270 kB +380 B (+0.1%)
react-native 270 kB 270 kB +380 B (+0.1%)

`@firebase/firestore-lite`

Type	Base (`89dac6c`)	Merge (`ba463fd`)	Diff
browser	84.0 kB	84.4 kB	+363 B (+0.4%)
esm5	101 kB	101 kB	+393 B (+0.4%)
main	143 kB	143 kB	+611 B (+0.4%)
module	84.0 kB	84.4 kB	+363 B (+0.4%)
react-native	84.2 kB	84.6 kB	+363 B (+0.4%)

`bundle`

Type	Base (`89dac6c`)	Merge (`ba463fd`)	Diff
firestore (Query Cursors)	212 kB	216 kB	+4.32 kB (+2.0%)
firestore (Query)	213 kB	214 kB	+983 B (+0.5%)
firestore-lite (Query Cursors)	73.7 kB	77.8 kB	+4.14 kB (+5.6%)
firestore-lite (Query)	73.0 kB	74.0 kB	+966 B (+1.3%)

`firebase`

Type	Base (`89dac6c`)	Merge (`ba463fd`)	Diff
firebase-compat.js	743 kB	744 kB	+967 B (+0.1%)
firebase-firestore-compat.js	318 kB	319 kB	+967 B (+0.3%)
firebase-firestore-lite.js	89.4 kB	89.7 kB	+363 B (+0.4%)
firebase-firestore.js	317 kB	318 kB	+382 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ts52Gg8AAg.html

google-oss-bot · 2022-11-12T01:43:46Z

Size Analysis Report ¹

This report is too large (104,783 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/5TUfcczNAz.html

… is offered.

packages/firestore/src/lite-api/query.ts

…'s still compatible with the overload signatures, but the constrained parameters simplfies the implementation.

packages/firestore/src/lite-api/query.ts

MarkDuckworth added 30 commits June 24, 2022 14:53

Add composite filters. Port of firebase/firebase-android-sdk#3290

effced9

Cleanup: lint

eba3b84

Support encoding and decoding Composite Filters

33a0896

Formatting

9f6e216

Merge remote-tracking branch 'origin/markduckworth/or-queries' into m…

6556240

…arkduckworth/or-queries-pr-3

Fix issue with readonly array.

78a8900

WIP: serving results from index.

80fc05d

Perform DNF transform

8b6f05f

Cleanup and tests from firebase/firebase-android-sdk#3444

152fc18

Merge branch 'markduckworth/or-queries' of github.com:firebase/fireba…

8b0bfbd

…se-js-sdk into markduckworth/or-queries-pr-4

use index if we have composite filters

1c948cb

Merge branch 'markduckworth/or-queries' into markduckworth/or-queries…

2cad46c

…-pr-4

Fix bad import

266f7f6

Update the orderBy filtering mechanism for OR queries and steps to se…

c2d7cd2

…rve OR queries from client-side index.

Adding tests

41d0e29

Test for DNF computation.

90f7c50

Fix implementation of isFlatConjunction

ff52ecc

Adding integration tests for validation of composite queries.

dfda9f8

IndexDb manager tests for partial and full index.

9bc3336

Test query does not include documents with missing fields

d66abd4

Run prettier

e33263d

Add missing awaits

01c3487

Fixing argument validation for and . Updating tests for asserted erro…

7d56b57

…r messages.

Prettier

d01ff74

Removing duplicate test cases.

186fd92

Update proto with OR operator.

409b19c

Update protos with OR operator.

131f4be

Testing query with indexes

a514358

Add compile.sh to compile proto updates.

0ab215b

Adding new script to run browser tests against the emulator.

638b0ad

MarkDuckworth added 9 commits October 28, 2022 10:50

Compute IN expansion.

ff0eede

Fix edge case a == 1 && a == 6

66bf749

Logic utils tests for in expansion.

968d133

Fixed rogue comment.

5f37954

Comment cleanup.

ab5cad2

Comment cleanup.

5fa9c76

Test refactoring.

9c6395b

Collapsing duplicate tests that covered with and without client side …

09046e7

…indexing into one test case that executes with both configurations.

Additional validation and additional validation tests for where(..), …

ed0e192

…and(...), and or(...).

MarkDuckworth requested review from dwyfrequency and hsubox76 as code owners November 12, 2022 00:40

Fixed type-o in error message.

99c7ef8

MarkDuckworth assigned ehsannas Nov 12, 2022

Merge branch 'markduckworth/or-queries' of github.com:firebase/fireba…

789c481

…se-js-sdk into markduckworth/or-queries-pr-10

Tagging all new OR Query API members as internal until server support…

c3c7afb

… is offered.

ehsannas approved these changes Nov 14, 2022

View reviewed changes

packages/firestore/src/lite-api/query.ts Outdated Show resolved Hide resolved

ehsannas assigned MarkDuckworth and unassigned ehsannas Nov 15, 2022

MarkDuckworth added 2 commits November 15, 2022 11:07

Constrained the parameters of the query() function implementation. It…

fb662cd

…'s still compatible with the overload signatures, but the constrained parameters simplfies the implementation.

Lint and formatting.

8405c97

ehsannas reviewed Nov 15, 2022

View reviewed changes

packages/firestore/src/lite-api/query.ts Outdated Show resolved Hide resolved

query() implementation cleaner param names and types.

99fb4b9

ehsannas approved these changes Nov 16, 2022

View reviewed changes

Changing queryConstraint param from optional to union undefined.

bfaac63

MarkDuckworth merged commit a0fb0aa into markduckworth/or-queries Nov 16, 2022

MarkDuckworth deleted the markduckworth/or-queries-pr-10 branch November 16, 2022 21:53

firebase locked and limited conversation to collaborators Dec 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OR queries more validation #6785

OR queries more validation #6785

Uh oh!

MarkDuckworth commented Nov 12, 2022

Uh oh!

changeset-bot bot commented Nov 12, 2022 •

edited

Loading

Uh oh!

google-oss-bot commented Nov 12, 2022 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented Nov 12, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OR queries more validation #6785

OR queries more validation #6785

Uh oh!

Conversation

MarkDuckworth commented Nov 12, 2022

Uh oh!

changeset-bot bot commented Nov 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Nov 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Nov 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Nov 12, 2022 •

edited

Loading

google-oss-bot commented Nov 12, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Nov 12, 2022 •

edited

Loading

Size Analysis Report ¹