Skip to content

Revert "TypeScript 4.7.4 upgrade for Firestore" #6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "TypeScript 4.7.4 upgrade for Firestore" #6829

wants to merge 2 commits into from

Conversation

dconeybe
Copy link
Contributor

This reverts #6796 which upgraded TypeScript to 4.7.4 for Firestore. The revert is being done because the upgrade somehow broke the browser tests in GitHub Actions. I'm going to investigate and re-push the upgrade once the root cause of the browser test failures is found and fixed.

@dconeybe
Revert "TypeScript 4.7.4 upgrade for Firestore (#6796)"
9514b13 
This reverts commit ab3f16c (#6796) because it (somehow?) caused the browser tests to fail in GitHub Actions.
@dconeybe dconeybe requested a review from egilmorez as a code owner November 24, 2022 18:36
@dconeybe dconeybe self-assigned this Nov 24, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 37ec7cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
@firebase/firestore-compat Minor
firebase Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 24, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (fde5adf)Merge (83e6531)Diff
    browser272 kB272 kB+46 B (+0.0%)
    esm5339 kB337 kB-1.67 kB (-0.5%)
    main545 kB545 kB+14 B (+0.0%)
    module272 kB272 kB+46 B (+0.0%)
    react-native272 kB272 kB+46 B (+0.0%)

  • @firebase/firestore-compat

    TypeBase (fde5adf)Merge (83e6531)Diff
    esm527.6 kB27.6 kB-49 B (-0.2%)

  • @firebase/firestore-lite

    TypeBase (fde5adf)Merge (83e6531)Diff
    browser85.9 kB85.9 kB-10 B (-0.0%)
    esm5104 kB103 kB-881 B (-0.8%)
    main146 kB146 kB-10 B (-0.0%)
    module85.9 kB85.9 kB-10 B (-0.0%)
    react-native86.1 kB86.1 kB-10 B (-0.0%)

  • bundle

    12 size changes

    TypeBase (fde5adf)Merge (83e6531)Diff
    firestore (Persistence)281 kB281 kB+23 B (+0.0%)
    firestore (Query Cursors)220 kB220 kB+23 B (+0.0%)
    firestore (Query)217 kB217 kB+23 B (+0.0%)
    firestore (Read data once)204 kB204 kB+23 B (+0.0%)
    firestore (Realtime updates)207 kB207 kB+23 B (+0.0%)
    firestore (Transaction)188 kB188 kB+23 B (+0.0%)
    firestore (Write data)188 kB188 kB+23 B (+0.0%)
    firestore-lite (Query Cursors)81.0 kB81.0 kB-10 B (-0.0%)
    firestore-lite (Query)77.2 kB77.1 kB-10 B (-0.0%)
    firestore-lite (Read data once)59.1 kB59.1 kB-10 B (-0.0%)
    firestore-lite (Transaction)83.7 kB83.7 kB-10 B (-0.0%)
    firestore-lite (Write data)68.9 kB68.9 kB-10 B (-0.0%)

  • firebase

    TypeBase (fde5adf)Merge (83e6531)Diff
    firebase-compat.js746 kB746 kB+20 B (+0.0%)
    firebase-firestore-compat.js319 kB319 kB+20 B (+0.0%)
    firebase-firestore-lite.js92.6 kB92.5 kB-10 B (-0.0%)
    firebase-firestore.js321 kB321 kB+46 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bGZuJxjj9U.html

@dconeybe
Copy link
Contributor Author

Hmm, this didn't fix the github actions failures at all. Closing.

@dconeybe dconeybe closed this Nov 24, 2022
@dconeybe dconeybe deleted the dconeybe/TypeScript474UpgradeRevert branch November 24, 2022 19:11
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 24, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • addDoc

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size118 kB118 kB+23 B (+0.0%)
      size-with-ext-deps177 kB177 kB+23 B (+0.0%)

    • deleteDoc

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size109 kB109 kB+23 B (+0.0%)
      size-with-ext-deps168 kB168 kB+23 B (+0.0%)

    • disableNetwork

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size97.4 kB97.5 kB+23 B (+0.0%)
      size-with-ext-deps157 kB157 kB+23 B (+0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size179 kB179 kB+23 B (+0.0%)
      size-with-ext-deps238 kB238 kB+23 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size211 kB211 kB+23 B (+0.0%)
      size-with-ext-deps271 kB271 kB+23 B (+0.0%)

    • enableNetwork

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size97.4 kB97.4 kB+23 B (+0.0%)
      size-with-ext-deps157 kB157 kB+23 B (+0.0%)

    • executeWrite

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size108 kB108 kB+23 B (+0.0%)
      size-with-ext-deps168 kB168 kB+23 B (+0.0%)

    • getCountFromServer

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size104 kB104 kB+23 B (+0.0%)
      size-with-ext-deps164 kB164 kB+23 B (+0.0%)

    • getDoc

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size135 kB135 kB+23 B (+0.0%)
      size-with-ext-deps194 kB194 kB+23 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size135 kB135 kB+23 B (+0.0%)
      size-with-ext-deps194 kB194 kB+23 B (+0.0%)

    • getDocs

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size136 kB136 kB+23 B (+0.0%)
      size-with-ext-deps196 kB196 kB+23 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size136 kB136 kB+23 B (+0.0%)
      size-with-ext-deps196 kB196 kB+23 B (+0.0%)

    • loadBundle

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size106 kB106 kB+23 B (+0.0%)
      size-with-ext-deps166 kB166 kB+23 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size137 kB137 kB+23 B (+0.0%)
      size-with-ext-deps196 kB196 kB+23 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size126 kB126 kB+23 B (+0.0%)
      size-with-ext-deps186 kB186 kB+23 B (+0.0%)

    • runTransaction

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size118 kB118 kB+23 B (+0.0%)
      size-with-ext-deps177 kB177 kB+23 B (+0.0%)

    • setDoc

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size117 kB117 kB+23 B (+0.0%)
      size-with-ext-deps177 kB177 kB+23 B (+0.0%)

    • setIndexConfiguration

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size86.6 kB86.6 kB+23 B (+0.0%)
      size-with-ext-deps146 kB146 kB+23 B (+0.0%)

    • updateDoc

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size118 kB118 kB+23 B (+0.0%)
      size-with-ext-deps177 kB177 kB+23 B (+0.0%)

    • waitForPendingWrites

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size97.9 kB97.9 kB+23 B (+0.0%)
      size-with-ext-deps157 kB157 kB+23 B (+0.0%)

    • writeBatch

      Size

      TypeBase (fde5adf)Merge (83e6531)Diff
      size120 kB120 kB+23 B (+0.0%)
      size-with-ext-deps179 kB179 kB+23 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EXJEcP81uf.html

@firebase firebase locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez Awaiting requested review from egilmorez

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @google-oss-bot