Skip to content

Fixed issue where we call connectDatabaseToEmulator twice #6883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2022
Merged

Fixed issue where we call connectDatabaseToEmulator twice #6883

merged 5 commits into from
Dec 13, 2022

Conversation

maneesht
Copy link
Contributor

Fixes #6853

@maneesht maneesht requested review from jsdt and jmwski as code owners December 13, 2022 20:34
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 8a9fbc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jamesdaniels
jamesdaniels approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maneesht maneesht assigned jmwski and unassigned jamesdaniels Dec 13, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 13, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (37f31c5)Merge (e34585e)Diff
    browser247 kB247 kB+26 B (+0.0%)
    esm5276 kB276 kB+26 B (+0.0%)
    main281 kB281 kB+26 B (+0.0%)
    module247 kB247 kB+26 B (+0.0%)

  • bundle

    TypeBase (37f31c5)Merge (e34585e)Diff
    database (Append to a list of data)148 kB148 kB+25 B (+0.0%)
    database (Filtering data)147 kB147 kB+25 B (+0.0%)
    database (Listen for child events)163 kB163 kB+25 B (+0.0%)
    database (Listen for value events + Detach listeners)163 kB163 kB+25 B (+0.0%)
    database (Listen for value events)163 kB163 kB+25 B (+0.0%)
    database (Read data once)163 kB163 kB+25 B (+0.0%)
    database (Save data as transactions)165 kB165 kB+25 B (+0.0%)
    database (Sort data)148 kB148 kB+25 B (+0.0%)
    database (Write data)147 kB147 kB+25 B (+0.0%)

  • firebase

    TypeBase (37f31c5)Merge (e34585e)Diff
    firebase-database.js154 kB154 kB+30 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/V76EcgYs0M.html

jmwski
jmwski reviewed Dec 13, 2022
View reviewed changes
@maneesht maneesht requested a review from egilmorez as a code owner December 13, 2022 21:12
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 13, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/database

    • getDatabase

      Size

      TypeBase (37f31c5)Merge (e34585e)Diff
      size117 kB117 kB+25 B (+0.0%)
      size-with-ext-deps146 kB146 kB+25 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CQ8Gbizqsa.html

@maneesht maneesht merged commit d8af08f into master Dec 13, 2022
@maneesht maneesht deleted the mtewani/fix-connect-database branch December 13, 2022 22:00
@firebase firebase locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

@jmwski jmwski jmwski approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@jmwski jmwski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database tries to call connectDatabaseEmulator when already initialized, leading to FIREBASE FATAL ERROR
5 participants
@maneesht @google-oss-bot @jamesdaniels @jmwski @hsubox76