Improve performance by using getAll on IDBIndex.

[tom-andersen]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 832337d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/firestore

  Type	Base (ac10cc3)	Merge (6e147d5)	Diff
  browser	374 kB	374 kB	+20 B (+0.0%)
  esm5	360 kB	360 kB	+20 B (+0.0%)
  main	576 kB	576 kB	+50 B (+0.0%)
  module	374 kB	374 kB	+20 B (+0.0%)
  react-native	374 kB	374 kB	+20 B (+0.0%)

• bundle

  Type	Base (ac10cc3)	Merge (6e147d5)	Diff
  firestore (Persistence)	302 kB	302 kB	+20 B (+0.0%)

• firebase

  Type	Base (ac10cc3)	Merge (6e147d5)	Diff
  firebase-compat.js	779 kB	779 kB	+22 B (+0.0%)
  firebase-firestore-compat.js	340 kB	340 kB	+22 B (+0.0%)
  firebase-firestore.js	434 kB	434 kB	+20 B (+0.0%)

Test Logs

• Base (ac10cc3): https://github.com/firebase/firebase-js-sdk/actions/runs/7066970757
• Merge (6e147d5): https://github.com/firebase/firebase-js-sdk/actions/runs/7093718395

1. https://storage.googleapis.com/firebase-sdk-metric-reports/8VaHFmRLMb.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

• @firebase/firestore

  • clearIndexedDbPersistence

    Size

    Type	Base (ac10cc3)	Merge (6e147d5)	Diff
    size	26.5 kB	26.5 kB	+20 B (+0.1%)
    size-with-ext-deps	96.5 kB	96.6 kB	+20 B (+0.0%)

  • enableIndexedDbPersistence

    Size

    Type	Base (ac10cc3)	Merge (6e147d5)	Diff
    size	186 kB	186 kB	+20 B (+0.0%)
    size-with-ext-deps	258 kB	258 kB	+20 B (+0.0%)

  • enableMultiTabIndexedDbPersistence

    Size

    Type	Base (ac10cc3)	Merge (6e147d5)	Diff
    size	221 kB	221 kB	+20 B (+0.0%)
    size-with-ext-deps	293 kB	294 kB	+20 B (+0.0%)

  • persistentLocalCache

    Size

    Type	Base (ac10cc3)	Merge (6e147d5)	Diff
    size	183 kB	183 kB	+20 B (+0.0%)
    size-with-ext-deps	255 kB	255 kB	+20 B (+0.0%)

  • persistentMultipleTabManager

    Size

    Type	Base (ac10cc3)	Merge (6e147d5)	Diff
    size	218 kB	218 kB	+20 B (+0.0%)
    size-with-ext-deps	290 kB	290 kB	+20 B (+0.0%)

  • persistentSingleTabManager

    Size

    Type	Base (ac10cc3)	Merge (6e147d5)	Diff
    size	182 kB	182 kB	+20 B (+0.0%)
    size-with-ext-deps	254 kB	254 kB	+20 B (+0.0%)

Test Logs

• Base (ac10cc3): https://github.com/firebase/firebase-js-sdk/actions/runs/7066970757
• Merge (6e147d5): https://github.com/firebase/firebase-js-sdk/actions/runs/7093718395

1. https://storage.googleapis.com/firebase-sdk-metric-reports/4srYzV5EE5.html

[MarkDuckworth]

LGTM. But do we have a way to test the new code path using getAll with an index? Or will that already be covered in the tests we do across different browsers?

[tom-andersen]

LGTM. But do we have a way to test the new code path using getAll with an index? Or will that already be covered in the tests we do across different browsers?

The test:browser scripts will run this and pass.