Skip to content

Update Auth CODEOWNERS #6990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

Update Auth CODEOWNERS #6990

merged 1 commit into from
Feb 3, 2023

Conversation

prameshj
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 932779b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lisajian
lisajian reviewed Jan 30, 2023
View reviewed changes
lisajian
lisajian approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@lisajian lisajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending approval from the others so they're aware of the change too - thanks Pavithra!

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (825e648) and merge commit (8154011).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EM3kE5U3rZ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (825e648) and merge commit (bb92184).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/T3YQZtYNfP.html

@prameshj prameshj merged commit ac5cc6e into master Feb 3, 2023
@prameshj prameshj deleted the prameshj-patch-1 branch February 3, 2023 22:35
@firebase firebase locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@lisajian lisajian lisajian approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prameshj @google-oss-bot @sam-gc @hsubox76 @lisajian