One neat trick to fix slow builds #7036
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (c36f3ab) and merge commit (b206840).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (c36f3ab) and merge commit (b206840).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
firebasemain package builds ignore all dist files even in subdirectories. This was causing very slow builds inrollup-plugin-typescript2(30-50s per small index file). This didn't seem to be a problem in the past (perhaps a change to rpt2 or typescript introduced this), and it's not a problem for@rollup/plugin-typescriptwhich doesn't even seem to need theexcludeto know to ignoredist/files.This reduces build times per file from roughly 30s to about 3s.