Skip to content

Align recaptcha error codes with Android and make recaptcha config internal #7144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 4, 2023
Merged

Align recaptcha error codes with Android and make recaptcha config internal #7144

merged 14 commits into from
Apr 4, 2023

Conversation

renkelvin
Copy link

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f8bc16b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 21, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (c51f120)Merge (7fa04b5)Diff
    browser168 kB170 kB+1.18 kB (+0.7%)
    cordova195 kB197 kB+1.25 kB (+0.6%)
    esm5220 kB222 kB+1.25 kB (+0.6%)
    main165 kB166 kB+1.25 kB (+0.8%)
    module168 kB170 kB+1.18 kB (+0.7%)
    react-native180 kB182 kB+1.25 kB (+0.7%)

  • @firebase/auth/cordova

    TypeBase (c51f120)Merge (7fa04b5)Diff
    browser195 kB197 kB+1.25 kB (+0.6%)
    module195 kB197 kB+1.25 kB (+0.6%)

  • @firebase/auth/internal

    TypeBase (c51f120)Merge (7fa04b5)Diff
    browser179 kB180 kB+1.18 kB (+0.7%)
    esm5234 kB235 kB+1.25 kB (+0.5%)
    main201 kB202 kB+1.25 kB (+0.6%)
    module179 kB180 kB+1.18 kB (+0.7%)

  • @firebase/auth/react-native

    TypeBase (c51f120)Merge (7fa04b5)Diff
    browser180 kB182 kB+1.25 kB (+0.7%)
    module180 kB182 kB+1.25 kB (+0.7%)

  • bundle

    TypeBase (c51f120)Merge (7fa04b5)Diff
    auth (Anonymous)70.4 kB70.6 kB+217 B (+0.3%)
    auth (EmailAndPassword)75.3 kB75.6 kB+246 B (+0.3%)
    auth (GoogleFBTwitterGitHubPopup)96.5 kB96.7 kB+217 B (+0.2%)
    auth (GooglePopup)93.7 kB93.9 kB+217 B (+0.2%)
    auth (GoogleRedirect)94.0 kB94.2 kB+217 B (+0.2%)
    auth (Phone)80.3 kB80.5 kB+217 B (+0.3%)

  • firebase

    TypeBase (c51f120)Merge (7fa04b5)Diff
    firebase-auth-compat.js131 kB132 kB+903 B (+0.7%)
    firebase-auth-cordova.js145 kB146 kB+1.25 kB (+0.9%)
    firebase-auth-react-native.js158 kB159 kB+1.25 kB (+0.8%)
    firebase-auth.js125 kB126 kB+1.22 kB (+1.0%)
    firebase-compat.js755 kB756 kB+903 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EqH1ZEMhRi.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 21, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (137,371 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vuV7PzROYS.html

@renkelvin renkelvin changed the title Update create_auth_uri.test.ts Align recaptcha error codes with Android and make recaptcha config internal Mar 22, 2023
@renkelvin renkelvin marked this pull request as ready for review March 24, 2023 20:11
prameshj
prameshj reviewed Mar 25, 2023
View reviewed changes
prameshj
prameshj reviewed Mar 30, 2023
View reviewed changes
prameshj
prameshj approved these changes Apr 3, 2023
View reviewed changes
@renkelvin
Copy link
Author

Gonna fix Update API reports / Update API reports when merging the feature branch(recaptcha-public-preview) to master.

@renkelvin renkelvin merged commit ea4a577 into recaptcha-public-preview Apr 4, 2023
@renkelvin renkelvin deleted the pp-test branch April 4, 2023 00:15
renkelvin pushed a commit that referenced this pull request Apr 4, 2023
Align recaptcha error codes with Android and make recaptcha config in…
28b7778 
…ternal (#7144)
@firebase firebase locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bhparijat bhparijat bhparijat left review comments

@prameshj prameshj prameshj approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@markarndt markarndt Awaiting requested review from markarndt

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renkelvin @google-oss-bot @bhparijat @prameshj