Skip to content

Firestore: use unique collection names in integration tests #7235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

dconeybe
Copy link
Contributor

Fix some Firestore integration tests to use uniquely-generated collection names rather than hardcoding the collection names. This ensures that concurrently-executing tests will not interfere with each other.

There have recently been a few flakes, such as in the supports partials with merge test that could be explained by concurrently-executing tests both manipulating the same collection. By uniquely generating the collection ID this possibility is eliminated.

@dconeybe dconeybe self-assigned this Apr 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

⚠️ No Changeset found

Latest commit: e071468

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dconeybe dconeybe requested a review from wu-hui April 19, 2023 15:26
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Apr 19, 2023
@dconeybe dconeybe assigned dconeybe and unassigned wu-hui Apr 19, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 19, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 19, 2023

@dconeybe dconeybe merged commit 6f9d7b1 into master Apr 19, 2023
@dconeybe dconeybe deleted the dconeybe/IntegrationTestRobustness branch April 19, 2023 17:23
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants