Skip to content

Fail open and send auth request to the GCIP backend if Recaptcha toke… #7254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2023
Merged

Fail open and send auth request to the GCIP backend if Recaptcha toke… #7254

merged 6 commits into from
Apr 25, 2023

Conversation

renkelvin
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7fad65c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    browser171 kB171 kB+3 B (+0.0%)
    cordova198 kB198 kB-1 B (-0.0%)
    esm5223 kB223 kB-1 B (-0.0%)
    main168 kB168 kB-1 B (-0.0%)
    module171 kB171 kB+3 B (+0.0%)
    react-native183 kB183 kB-1 B (-0.0%)

  • @firebase/auth/cordova

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    browser198 kB198 kB-1 B (-0.0%)
    module198 kB198 kB-1 B (-0.0%)

  • @firebase/auth/internal

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    browser181 kB181 kB+3 B (+0.0%)
    esm5237 kB237 kB-1 B (-0.0%)
    main204 kB204 kB-1 B (-0.0%)
    module181 kB181 kB+3 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    browser183 kB183 kB-1 B (-0.0%)
    module183 kB183 kB-1 B (-0.0%)

  • @firebase/firestore

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    browser285 kB285 kB+111 B (+0.0%)
    esm5354 kB354 kB+127 B (+0.0%)
    main567 kB567 kB+121 B (+0.0%)
    module285 kB285 kB+111 B (+0.0%)
    react-native285 kB285 kB+111 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    browser87.7 kB87.5 kB-190 B (-0.2%)
    esm5106 kB105 kB-174 B (-0.2%)
    main149 kB149 kB-180 B (-0.1%)
    module87.7 kB87.5 kB-190 B (-0.2%)
    react-native87.9 kB87.7 kB-190 B (-0.2%)

  • bundle

    43 size changes

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    analytics (logEvent)43.7 kB43.8 kB+57 B (+0.1%)
    app-check (CustomProvider)36.2 kB36.3 kB+57 B (+0.2%)
    app-check (ReCaptchaEnterpriseProvider)38.8 kB38.8 kB+57 B (+0.1%)
    app-check (ReCaptchaV3Provider)38.7 kB38.8 kB+57 B (+0.1%)
    auth (Anonymous)71.1 kB71.2 kB+64 B (+0.1%)
    auth (EmailAndPassword)76.1 kB76.2 kB+64 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)97.3 kB97.4 kB+64 B (+0.1%)
    auth (GooglePopup)94.6 kB94.7 kB+64 B (+0.1%)
    auth (GoogleRedirect)94.8 kB94.9 kB+64 B (+0.1%)
    auth (Phone)81.0 kB81.1 kB+64 B (+0.1%)
    database (Append to a list of data)148 kB148 kB+57 B (+0.0%)
    database (Filtering data)147 kB147 kB+57 B (+0.0%)
    database (Listen for child events)164 kB164 kB+57 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+57 B (+0.0%)
    database (Listen for value events)163 kB163 kB+57 B (+0.0%)
    database (Read data once)163 kB163 kB+57 B (+0.0%)
    database (Save data as transactions)165 kB166 kB+57 B (+0.0%)
    database (Sort data)149 kB149 kB+57 B (+0.0%)
    database (Write data)147 kB147 kB+57 B (+0.0%)
    firestore (Persistence)298 kB298 kB+358 B (+0.1%)
    firestore (Query Cursors)236 kB237 kB+401 B (+0.2%)
    firestore (Query)234 kB234 kB+401 B (+0.2%)
    firestore (Read data once)221 kB222 kB+401 B (+0.2%)
    firestore (Realtime updates)223 kB224 kB+401 B (+0.2%)
    firestore (Transaction)201 kB201 kB+120 B (+0.1%)
    firestore (Write data)200 kB201 kB+57 B (+0.0%)
    firestore-lite (Query Cursors)81.6 kB81.7 kB+120 B (+0.1%)
    firestore-lite (Query)77.7 kB77.9 kB+120 B (+0.2%)
    firestore-lite (Read data once)59.9 kB60.0 kB+120 B (+0.2%)
    firestore-lite (Transaction)84.7 kB84.8 kB+120 B (+0.1%)
    firestore-lite (Write data)69.5 kB69.6 kB+57 B (+0.1%)
    functions (call)31.0 kB31.1 kB+57 B (+0.2%)
    messaging (send + receive)46.5 kB46.5 kB+71 B (+0.2%)
    performance (trace)50.9 kB51.0 kB+57 B (+0.1%)
    remote-config (getAndFetch)45.4 kB45.5 kB+57 B (+0.1%)
    storage (getBytes)41.2 kB41.3 kB+57 B (+0.1%)
    storage (getDownloadURL)43.3 kB43.4 kB+57 B (+0.1%)
    storage (getMetadata)42.8 kB42.8 kB+57 B (+0.1%)
    storage (list + listAll)42.2 kB42.2 kB+57 B (+0.1%)
    storage (updateMetadata)43.0 kB43.1 kB+57 B (+0.1%)
    storage (uploadBytes)48.1 kB48.2 kB+57 B (+0.1%)
    storage (uploadBytesResumable)58.1 kB58.1 kB+57 B (+0.1%)
    storage (uploadString)48.3 kB48.4 kB+57 B (+0.1%)

  • firebase

    23 size changes

    TypeBase (f5aec7b)Merge (76c7d41)Diff
    firebase-analytics-compat.js26.4 kB26.5 kB+54 B (+0.2%)
    firebase-analytics.js25.7 kB25.8 kB+54 B (+0.2%)
    firebase-app-compat.js28.9 kB28.9 kB+54 B (+0.2%)
    firebase-app.js93.1 kB93.3 kB+222 B (+0.2%)
    firebase-auth-compat.js132 kB132 kB-5 B (-0.0%)
    firebase-auth-cordova.js147 kB147 kB-7 B (-0.0%)
    firebase-auth-react-native.js160 kB160 kB-7 B (-0.0%)
    firebase-auth.js127 kB127 kB-5 B (-0.0%)
    firebase-compat.js771 kB772 kB+426 B (+0.1%)
    firebase-firestore-compat.js338 kB338 kB+364 B (+0.1%)
    firebase-firestore-lite.js94.4 kB94.2 kB-190 B (-0.2%)
    firebase-firestore.js344 kB344 kB+111 B (+0.0%)
    firebase-installations-compat.js13.2 kB13.3 kB+54 B (+0.4%)
    firebase-installations.js12.5 kB12.5 kB+54 B (+0.4%)
    firebase-messaging-compat.js38.2 kB38.3 kB+67 B (+0.2%)
    firebase-messaging-sw.js26.0 kB26.1 kB+67 B (+0.3%)
    firebase-messaging.js24.8 kB24.9 kB+67 B (+0.3%)
    firebase-performance-compat.js30.7 kB30.8 kB+54 B (+0.2%)
    firebase-performance-standalone-compat.es2017.js90.0 kB90.1 kB+54 B (+0.1%)
    firebase-performance-standalone-compat.js67.2 kB67.2 kB+54 B (+0.1%)
    firebase-performance.js30.8 kB30.8 kB+54 B (+0.2%)
    firebase-remote-config-compat.js27.2 kB27.3 kB+54 B (+0.2%)
    firebase-remote-config.js26.3 kB26.3 kB+54 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZtGf4c4KSH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (900,016 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GinVPRVysG.html

@renkelvin renkelvin marked this pull request as ready for review April 25, 2023 04:40
@renkelvin renkelvin requested review from lisajian, prameshj, sam-gc and a team as code owners April 25, 2023 04:41
prameshj
prameshj reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minor nits.

@renkelvin renkelvin merged commit 623dba3 into master Apr 25, 2023
@renkelvin renkelvin deleted the fail-open branch April 25, 2023 19:48
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renkelvin @google-oss-bot @prameshj