Skip to content

Fix GITHUB_OUTPUT statements #7267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix GITHUB_OUTPUT statements #7267

merged 1 commit into from
Apr 26, 2023

Conversation

hsubox76
Copy link
Contributor

GITHUB_OUTPUT is the correct env variable to set to be referenceable by steps.[stepname].output in following steps.

detect-doc-changes.ts had the same problem, but the file isn't used anymore due to removing the docs-changed.yml workflow, so I removed that file.

release-staging.yml also has this problem, but it also needs other fixes so that will be done in a separate PR.

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

⚠️ No Changeset found

Latest commit: cd4ee15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 26, 2023 17:11
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners April 26, 2023 17:11
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 9f2ce14 into master Apr 26, 2023
@hsubox76 hsubox76 deleted the ch-fix-output branch April 26, 2023 17:59
@google-oss-bot
Copy link
Contributor

@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants