Skip to content

Raise error if calling initializeRecaptchaConfig in node env #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

renkelvin
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

🦋 Changeset detected

Latest commit: cd9c647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2023

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser14.4 kB14.4 kB+1 B (+0.0%)
    esm518.9 kB18.9 kB+1 B (+0.0%)
    main19.8 kB19.8 kB+1 B (+0.0%)
    module14.4 kB14.4 kB+1 B (+0.0%)
  • @firebase/app-check

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser26.2 kB26.2 kB+54 B (+0.2%)
    esm531.4 kB31.5 kB+69 B (+0.2%)
    main32.6 kB32.7 kB+69 B (+0.2%)
    module26.2 kB26.2 kB+54 B (+0.2%)
  • @firebase/app-compat

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser5.28 kB5.28 kB+1 B (+0.0%)
    esm56.13 kB6.13 kB+1 B (+0.0%)
    lite4.06 kB4.06 kB+1 B (+0.0%)
    main6.73 kB6.73 kB+1 B (+0.0%)
    module5.28 kB5.28 kB+1 B (+0.0%)
  • @firebase/auth

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser170 kB177 kB+6.20 kB (+3.6%)
    cordova198 kB206 kB+7.45 kB (+3.8%)
    esm5223 kB231 kB+7.50 kB (+3.4%)
    main167 kB175 kB+7.70 kB (+4.6%)
    module170 kB177 kB+6.20 kB (+3.6%)
    react-native183 kB189 kB+6.83 kB (+3.7%)
  • @firebase/auth/cordova

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser198 kB206 kB+7.45 kB (+3.8%)
    module198 kB206 kB+7.45 kB (+3.8%)
  • @firebase/auth/internal

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser181 kB188 kB+6.20 kB (+3.4%)
    esm5237 kB244 kB+7.50 kB (+3.2%)
    main204 kB211 kB+7.74 kB (+3.8%)
    module181 kB188 kB+6.20 kB (+3.4%)
  • @firebase/database

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser248 kB248 kB+748 B (+0.3%)
    esm5276 kB277 kB+815 B (+0.3%)
    main281 kB282 kB+927 B (+0.3%)
    module248 kB248 kB+748 B (+0.3%)
  • @firebase/database-compat

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser18.0 kB18.3 kB+289 B (+1.6%)
    esm521.1 kB21.4 kB+305 B (+1.4%)
    main21.8 kB22.2 kB+325 B (+1.5%)
    module18.0 kB18.3 kB+289 B (+1.6%)
  • @firebase/database-compat/standalone

    TypeBase (6feab89)Merge (c982dd5)Diff
    main370 kB371 kB+1.31 kB (+0.4%)
  • @firebase/firestore

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser286 kB371 kB+84.6 kB (+29.6%)
    esm5355 kB356 kB+1.20 kB (+0.3%)
    main568 kB569 kB+1.29 kB (+0.2%)
    module286 kB371 kB+84.6 kB (+29.6%)
    react-native286 kB371 kB+84.6 kB (+29.5%)
  • @firebase/firestore-compat

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser20.5 kB20.5 kB+1 B (+0.0%)
    esm527.6 kB27.6 kB+1 B (+0.0%)
    main20.9 kB20.9 kB+1 B (+0.0%)
    module20.5 kB20.5 kB+1 B (+0.0%)
    react-native20.5 kB20.5 kB+1 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser88.3 kB110 kB+21.8 kB (+24.7%)
    esm5106 kB107 kB+571 B (+0.5%)
    main151 kB152 kB+797 B (+0.5%)
    module88.3 kB110 kB+21.8 kB (+24.7%)
    react-native88.5 kB110 kB+21.8 kB (+24.6%)
  • @firebase/functions

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser9.55 kB9.72 kB+171 B (+1.8%)
    esm511.8 kB12.1 kB+257 B (+2.2%)
    main12.6 kB12.9 kB+257 B (+2.0%)
    module9.55 kB9.72 kB+171 B (+1.8%)
  • @firebase/performance

    TypeBase (6feab89)Merge (c982dd5)Diff
    browser29.1 kB29.1 kB-1 B (-0.0%)
    esm531.0 kB31.0 kB-1 B (-0.0%)
    main31.5 kB31.4 kB-1 B (-0.0%)
    module29.1 kB29.1 kB-1 B (-0.0%)
  • bundle

    33 size changes

    TypeBase (6feab89)Merge (c982dd5)Diff
    analytics (logEvent)43.8 kB43.8 kB+1 B (+0.0%)
    app-check (CustomProvider)36.3 kB36.6 kB+255 B (+0.7%)
    app-check (ReCaptchaEnterpriseProvider)38.8 kB39.1 kB+255 B (+0.7%)
    app-check (ReCaptchaV3Provider)38.8 kB39.1 kB+255 B (+0.7%)
    auth (Anonymous)71.1 kB72.6 kB+1.52 kB (+2.1%)
    auth (EmailAndPassword)76.1 kB79.9 kB+3.86 kB (+5.1%)
    auth (GoogleFBTwitterGitHubPopup)97.3 kB99.2 kB+1.90 kB (+2.0%)
    auth (GooglePopup)94.6 kB96.5 kB+1.90 kB (+2.0%)
    auth (GoogleRedirect)94.8 kB96.7 kB+1.90 kB (+2.0%)
    auth (Phone)81.0 kB82.9 kB+1.90 kB (+2.3%)
    firestore (Persistence)300 kB301 kB+1.46 kB (+0.5%)
    firestore (Query Cursors)238 kB239 kB+1.07 kB (+0.5%)
    firestore (Query)235 kB236 kB+1.07 kB (+0.5%)
    firestore (Read data once)223 kB224 kB+1.04 kB (+0.5%)
    firestore (Realtime updates)225 kB226 kB+1.04 kB (+0.5%)
    firestore (Transaction)202 kB203 kB+799 B (+0.4%)
    firestore (Write data)202 kB203 kB+842 B (+0.4%)
    firestore-lite (Query Cursors)82.6 kB83.1 kB+559 B (+0.7%)
    firestore-lite (Query)78.7 kB79.3 kB+551 B (+0.7%)
    firestore-lite (Read data once)60.9 kB61.3 kB+440 B (+0.7%)
    firestore-lite (Transaction)85.6 kB86.1 kB+493 B (+0.6%)
    firestore-lite (Write data)70.4 kB70.9 kB+439 B (+0.6%)
    functions (call)31.1 kB31.2 kB+74 B (+0.2%)
    messaging (send + receive)46.5 kB46.5 kB+1 B (+0.0%)
    remote-config (getAndFetch)45.5 kB45.5 kB+1 B (+0.0%)
    storage (getBytes)41.3 kB41.3 kB+1 B (+0.0%)
    storage (getDownloadURL)43.4 kB43.4 kB+1 B (+0.0%)
    storage (getMetadata)42.8 kB42.8 kB+1 B (+0.0%)
    storage (list + listAll)42.2 kB42.2 kB+1 B (+0.0%)
    storage (updateMetadata)43.1 kB43.1 kB+1 B (+0.0%)
    storage (uploadBytes)48.2 kB48.2 kB+1 B (+0.0%)
    storage (uploadBytesResumable)58.1 kB58.1 kB+1 B (+0.0%)
    storage (uploadString)48.4 kB48.4 kB+1 B (+0.0%)

  • firebase

    25 size changes

    TypeBase (6feab89)Merge (c982dd5)Diff
    firebase-analytics.js25.8 kB29.7 kB+3.92 kB (+15.2%)
    firebase-app-check-compat.js23.1 kB23.3 kB+246 B (+1.1%)
    firebase-app-check.js22.1 kB25.0 kB+2.92 kB (+13.2%)
    firebase-app-compat.js28.9 kB28.9 kB+3 B (+0.0%)
    firebase-app.js93.4 kB93.4 kB+1 B (+0.0%)
    firebase-auth-compat.js132 kB136 kB+4.03 kB (+3.0%)
    firebase-auth-cordova.js147 kB174 kB+26.9 kB (+18.3%)
    firebase-auth.js127 kB147 kB+20.3 kB (+16.0%)
    firebase-compat.js773 kB778 kB+5.30 kB (+0.7%)
    firebase-database-compat.js166 kB166 kB+132 B (+0.1%)
    firebase-database.js154 kB186 kB+31.7 kB (+20.6%)
    firebase-firestore-compat.js339 kB340 kB+823 B (+0.2%)
    firebase-firestore-lite.js95.0 kB118 kB+22.7 kB (+23.9%)
    firebase-firestore.js345 kB430 kB+84.8 kB (+24.5%)
    firebase-functions-compat.js8.12 kB8.19 kB+73 B (+0.9%)
    firebase-functions.js11.0 kB11.9 kB+963 B (+8.8%)
    firebase-installations.js12.5 kB15.1 kB+2.61 kB (+20.8%)
    firebase-messaging-sw.js26.1 kB30.1 kB+3.98 kB (+15.2%)
    firebase-messaging.js24.9 kB28.8 kB+3.88 kB (+15.6%)
    firebase-performance-compat.js30.8 kB30.8 kB-1 B (-0.0%)
    firebase-performance-standalone-compat.es2017.js90.1 kB90.1 kB+1 B (+0.0%)
    firebase-performance-standalone-compat.js67.3 kB67.3 kB+2 B (+0.0%)
    firebase-performance.js30.8 kB35.0 kB+4.23 kB (+13.7%)
    firebase-remote-config.js26.3 kB29.6 kB+3.22 kB (+12.2%)
    firebase-storage.js40.3 kB46.4 kB+6.16 kB (+15.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VmoKRuiXE1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2023

Size Analysis Report 1

This report is too large (2,666,038 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/w1zz8Xspxd.html

@renkelvin renkelvin changed the title Update index.ts Raise error if calling initializeRecaptchaConfig in node env May 8, 2023
@renkelvin renkelvin marked this pull request as ready for review May 8, 2023 22:07
@renkelvin renkelvin requested review from lisajian, prameshj, sam-gc and a team as code owners May 8, 2023 22:07
@renkelvin renkelvin requested a review from hsubox76 May 8, 2023 22:07
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see this earlier. Need a changeset (patch).

@renkelvin renkelvin requested review from a team as code owners August 7, 2023 22:17
@renkelvin renkelvin merged commit 6c7d079 into master Aug 8, 2023
@renkelvin renkelvin deleted the renkelvin-patch-1 branch August 8, 2023 18:27
@google-oss-bot google-oss-bot mentioned this pull request Aug 15, 2023
@firebase firebase locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants