Do docs check in one step #7289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DellaBitta
approved these changes
May 11, 2023
Size Report 1Affected ProductsNo changes between base commit (98d0b84) and merge commit (ed2e660).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (98d0b84) and merge commit (ed2e660).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the docs check in one step, and use the correct output variable (should be
$GITHUB_OUTPUTand notGITHUB_STATE). The "log to release tracker" step relies on this being output from the step with the iddocs-check, and not a later step. Also if this fails with an exit code it makes it look like the whole job failed which is bad UX, so removed that and just checked string length of output.