Skip to content

Fix an issue where TargetIndexMatcher rejects valid queries #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

Fix an issue where TargetIndexMatcher rejects valid queries #7335

merged 1 commit into from
May 30, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented May 30, 2023 •
edited
Loading

@wu-hui wu-hui requested review from a team as code owners May 30, 2023 14:34
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

⚠️ No Changeset found

Latest commit: ad709fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui requested a review from cherylEnkidu May 30, 2023 14:37
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (e642fc7)Merge (b9abfa4)Diff
    browser286 kB286 kB+95 B (+0.0%)
    esm5355 kB355 kB+95 B (+0.0%)
    main568 kB568 kB+197 B (+0.0%)
    module286 kB286 kB+95 B (+0.0%)
    react-native286 kB286 kB+95 B (+0.0%)

  • bundle

    TypeBase (e642fc7)Merge (b9abfa4)Diff
    firestore (Persistence)300 kB300 kB+95 B (+0.0%)

  • firebase

    TypeBase (e642fc7)Merge (b9abfa4)Diff
    firebase-compat.js773 kB773 kB+97 B (+0.0%)
    firebase-firestore-compat.js339 kB339 kB+97 B (+0.0%)
    firebase-firestore.js345 kB346 kB+95 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PuX4afX0gc.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (e642fc7)Merge (b9abfa4)Diff
      size183 kB183 kB+95 B (+0.1%)
      size-with-ext-deps254 kB254 kB+95 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (e642fc7)Merge (b9abfa4)Diff
      size219 kB219 kB+95 B (+0.0%)
      size-with-ext-deps291 kB291 kB+95 B (+0.0%)

    • persistentLocalCache

      Size

      TypeBase (e642fc7)Merge (b9abfa4)Diff
      size180 kB180 kB+95 B (+0.1%)
      size-with-ext-deps251 kB252 kB+95 B (+0.0%)

    • persistentMultipleTabManager

      Size

      TypeBase (e642fc7)Merge (b9abfa4)Diff
      size216 kB216 kB+95 B (+0.0%)
      size-with-ext-deps288 kB288 kB+95 B (+0.0%)

    • persistentSingleTabManager

      Size

      TypeBase (e642fc7)Merge (b9abfa4)Diff
      size179 kB180 kB+95 B (+0.1%)
      size-with-ext-deps251 kB251 kB+95 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YwHYpBzhCv.html

cherylEnkidu
cherylEnkidu approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

cherylEnkidu
cherylEnkidu approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wu-hui wu-hui merged commit 60e8538 into master May 30, 2023
@wu-hui wu-hui deleted the wuandy/FixFilterOnSameField branch May 30, 2023 17:06
ch5zzy pushed a commit that referenced this pull request Jun 6, 2023
@wu-hui @ch5zzy
Fix an issue where TargetIndexMatcher rejects valid queries (#7335)
96d9f74
@firebase firebase locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @cherylEnkidu