Skip to content

Fix issue with building sqlite3 package on Apple Silicone #7386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jun 22, 2023

Fix a Firestore build/testing issue by pinning sqlite3 to a newer version supported by Apple Silicone, otherwise indexeddbshim will pull in an older version.

This change only affects Firestore's Node integration tests.

@wu-hui wu-hui requested review from dwyfrequency, hsubox76 and a team as code owners June 22, 2023 16:25
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

⚠️ No Changeset found

Latest commit: 4d05b52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2023

@wu-hui wu-hui merged commit dd76dec into master Jun 22, 2023
@wu-hui wu-hui deleted the wuandy/FixSqliteOnM1 branch June 22, 2023 19:50
@firebase firebase locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants