-
Notifications
You must be signed in to change notification settings - Fork 944
Adding some style, formatting, and link fixes. #7432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (b58a617) and merge commit (190cd8b).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (b58a617) and merge commit (190cd8b).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Oh, the automatic part is the failed check that says to run yarn docgen devsite
. That will generate the md files in docs-devsite/
, and then you can check those in alongside the changed source files.
Just realized @zwu52 -- I mean this table: https://firebase.google.com/docs/reference/js/messaging_ But I'm also wondering about the other page . . . should that be enhanced with some descriptions and added to the TOC? That could be a separate effort/PR, but let's track the question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for the optimization
If I understand right, CI processes will stage these changes and create a staging link.
Kai, can you advise on missing descriptions for the bolded functions in this table: https://firebase.google.com/docs/reference/js/messaging_?
Thanks!