Skip to content

Adding some style, formatting, and link fixes. #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Adding some style, formatting, and link fixes. #7432

merged 2 commits into from
Jul 12, 2023

Conversation

egilmorez
Copy link
Contributor

If I understand right, CI processes will stage these changes and create a staging link.

Kai, can you advise on missing descriptions for the bolded functions in this table: https://firebase.google.com/docs/reference/js/messaging_?

Thanks!

@egilmorez egilmorez requested a review from a team as a code owner July 9, 2023 18:30
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2023

⚠️ No Changeset found

Latest commit: 6af4551

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 9, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 9, 2023

hsubox76
hsubox76 previously approved these changes Jul 10, 2023
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Oh, the automatic part is the failed check that says to run yarn docgen devsite. That will generate the md files in docs-devsite/, and then you can check those in alongside the changed source files.

@hsubox76 hsubox76 dismissed their stale review July 10, 2023 17:01

Need to generate docs first

@egilmorez
Copy link
Contributor Author

Just realized @zwu52 -- I mean this table: https://firebase.google.com/docs/reference/js/messaging_

But I'm also wondering about the other page . . . should that be enhanced with some descriptions and added to the TOC?

That could be a separate effort/PR, but let's track the question.

Copy link
Member

@zwu52 zwu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the optimization

@egilmorez egilmorez merged commit bcb1f1f into master Jul 12, 2023
@egilmorez egilmorez deleted the eg-tweaks branch July 12, 2023 16:46
@firebase firebase locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants